{{ message }}
bpo-32571: Avoid raising unneeded AttributeError and silencing it in C code (alt).#5222
Merged
methane merged 2 commits intoJan 25, 2018
Merged
Conversation
Member
Sorry, something went wrong.
…ode. Added _PyObject_GetAttrIdWithoutError() and used in appropriate cases.
…bject_LookupAttrId().
1st1
reviewed
Jan 17, 2018
methane
approved these changes
Jan 19, 2018
1st1
approved these changes
Jan 19, 2018
Member
|
@serhiy-storchaka Would you merge this? |
Sorry, something went wrong.
Member
|
I guess we can merge this ourselves if Serhiy isn't around. I'd like us to have this in 3.7. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Add
_PyObject_LookupAttr()and_PyObject_LookupAttrId()and use them in appropriate cases instead ofPyObject_GetAttr(),_PyObject_GetAttrId()and_PyObject_GetAttrIdWithoutError().https://bugs.python.org/issue32571