◐ Shell
reader mode source ↗
Skip to content

bpo-27505: Add version_added to docs for module attributes#5320

Merged
ncoghlan merged 3 commits into
python:masterfrom
csabella:bpo27505
Jan 27, 2018
Merged

bpo-27505: Add version_added to docs for module attributes#5320
ncoghlan merged 3 commits into
python:masterfrom
csabella:bpo27505

Conversation

@csabella

@csabella csabella commented Jan 25, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

csabella commented Jan 26, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@berkerpeksag berkerpeksag requested a review from ncoghlan January 26, 2018 13:16
@csabella

csabella commented Jan 26, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag
berkerpeksag approved these changes Jan 26, 2018
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thank you! I will wait for a bit to give @ncoghlan time to review before merging this.

@ncoghlan ncoghlan merged commit 85527cf into python:master Jan 27, 2018
@csabella csabella deleted the bpo27505 branch January 27, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csabella @bedevere-bot @berkerpeksag @ncoghlan @the-knights-who-say-ni