◐ Shell
reader mode source ↗
Skip to content

bpo-29514: Check magic number for bugfix release#54

Merged
ambv merged 3 commits into
python:masterfrom
appeltel:bpo-29514-magic-numbers
Apr 17, 2017
Merged

bpo-29514: Check magic number for bugfix release#54
ambv merged 3 commits into
python:masterfrom
appeltel:bpo-29514-magic-numbers

Conversation

@appeltel

@appeltel appeltel commented Feb 12, 2017 •
edited by ncoghlan
Loading

Copy link
Copy Markdown
Contributor

Add a test to check the current MAGIC_NUMBER against the
expected number for the release if the current release is
at candidate or final level. On test failure, describe to
the developer the procedure for changing the magic number.

https://bugs.python.org/issue29514

@appeltel
bpo-29514: Check magic number for micro release …
51835c7 
Add a dict importlib.util.EXPECTED_MAGIC_NUMBERS which
details the initial and expected pyc magic number for
each minor release. This gives a mechanism for users to
check if the magic number has changed within a release and
for a test to ensure procedure is followed if a change is
necessary.

Add a test to check the current MAGIC_NUMBER against the
expected number for the release if the current release is
at candidate or final level. On test failure, describe to
the developer the procedure for changing the magic number.
ncoghlan
ncoghlan requested changes Feb 12, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The general approach in the test case looks like it will give affected maintainers useful guidance, but the impact can be reduced by moving the EXPECTED_MAGIC_NUMBERS table into the test case itself (the test case will complain when it needs updating, so it's OK to have it separated from the list of actual magic numbers in the importlib code)

@appeltel
Simplify magic number release test …
9ea7c52 
Simplify the magic number release test by removing
EXPECTED_MAGIC_NUMBERS table and making the expected
magic number self-contained within the test.

BPO: 29514
ncoghlan
ncoghlan requested changes Mar 12, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This is looking pretty close now, just a couple of suggestions around details of the test execution.

@appeltel
Improve magic number test execution and message …
1e32a1b 
Improve the execution of the magic number test by
using skipUnless for alpha and beta releases, and
directly inheriting from unittest.TestCase rather than
using the machinery for the other tests. Also improve
the error message to explain the reason for caution in
changing the magic number.

BPO: 29514
@codecov

codecov Bot commented Mar 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #54 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1428       +1     
  Lines      350948   350968      +20     
==========================================
+ Hits       289093   289102       +9     
- Misses      61855    61866      +11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22bfaa...1e32a1b. Read the comment docs.

@ambv ambv merged commit d6d344d into python:master Apr 17, 2017
@miss-islington

miss-islington commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @appeltel for the PR, and @ambv for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6.

@miss-islington

miss-islington commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

Sorry @appeltel and @ambv, I had trouble checking out the 3.6 backport branch.
Please backport using cherry_picker on command line.

@miss-islington

miss-islington commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

Sorry, @appeltel and @ambv, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

@ncoghlan

ncoghlan commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

This was backported a while back, but I missed updating the labels:

2.7:#2160
3.5: #2158
3.6: #2157

lazka added a commit to lazka/cpython that referenced this pull request Nov 10, 2021
@lazka
distutils: remove checks for ancient gcc/binutils …
a69be8f 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
lazka added a commit to lazka/cpython that referenced this pull request Nov 21, 2021
@lazka
distutils: remove checks for ancient gcc/binutils …
8ec77b6 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 23, 2022
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
d25b393 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
28 hidden items Load more…
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 8, 2022
@lazka
distutils: remove checks for ancient gcc/binutils …
f359056 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
lazka added a commit to lazka/cpython that referenced this pull request Mar 2, 2023
@lazka
distutils: remove checks for ancient gcc/binutils …
7e1d329 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull request Mar 27, 2023
@pablogsal
Merge pull request python#54 from sunmy2019/handle-invalid-expressions
30ea09f
lazka added a commit to lazka/cpython that referenced this pull request Apr 7, 2023
@lazka
distutils: remove checks for ancient gcc/binutils …
3a04da2 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
lazka added a commit to lazka/cpython that referenced this pull request Apr 16, 2023
@lazka
distutils: remove checks for ancient gcc/binutils …
dc6119e 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 18, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
8d7310b 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 20, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
6909298 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
3f827c8 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
4f65c1e 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
86e3d50 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
abb666c 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
c6a75f1 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
9935034 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
d0b2083 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 23, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
7726bf7 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 24, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
1f016b6 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jun 25, 2023
@lazka @naveen521kk
distutils: remove checks for ancient gcc/binutils …
4d86299 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jul 12, 2023
@Fidget-Spinner
feat(ci): cache llvm installs across CI (python#54)
454b349
lazka added a commit to lazka/cpython that referenced this pull request Jul 28, 2023
@lazka
distutils: remove checks for ancient gcc/binutils …
075b6df 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
lazka added a commit to lazka/cpython that referenced this pull request Aug 27, 2023
@lazka
distutils: remove checks for ancient gcc/binutils …
b77c8c9 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
lazka added a commit to lazka/cpython that referenced this pull request Feb 10, 2024
@lazka
distutils: remove checks for ancient gcc/binutils …
59319ba 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
lazka added a commit to lazka/cpython that referenced this pull request Aug 25, 2024
@lazka
distutils: remove checks for ancient gcc/binutils …
bc6088b 
The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Closed
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@appeltel @miss-islington @ncoghlan @ambv @serhiy-storchaka @Mariatta @the-knights-who-say-ni