◐ Shell
reader mode source ↗
Skip to content

bpo-32705: Current Android does not have posix_spawn#5413

Merged
vstinner merged 1 commit into
python:masterfrom
yan12125:android-no-posix-spawn
Jan 29, 2018
Merged

bpo-32705: Current Android does not have posix_spawn#5413
vstinner merged 1 commit into
python:masterfrom
yan12125:android-no-posix-spawn

Conversation

@yan12125

@yan12125 yan12125 commented Jan 29, 2018

Copy link
Copy Markdown

@yan12125

Copy link
Copy Markdown
Author

I think a NEWS entry is not necessary as this patch is a fix to a new feature landed today (6c6ddf9). From https://devguide.python.org/committing/#what-s-new-and-news-entries:

If a change is a fix (or other adjustment) to an earlier unreleased change and the original news entry remains valid, then no additional entry is needed.

@gpshead gpshead added the type-bug An unexpected behavior, bug, or error label Jan 29, 2018
@gpshead gpshead self-assigned this Jan 29, 2018

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@vstinner

Copy link
Copy Markdown
Member

A better fix would be to check for posix_spawn() in configure, but it can be done later.

@yan12125

Copy link
Copy Markdown
Author

A better fix would be to check for posix_spawn() in configure, but it can be done later

I found there's already one: 6c6ddf9#diff-67e997bcfdac55191033d57a16d1408aR3434. Maybe the HAVE_POSIX_SPAWN define in posixmodule.c is not necessary?

@vstinner vstinner merged commit 8997f9c into python:master Jan 29, 2018
@bedevere-bot

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner

Copy link
Copy Markdown
Member

I found there's already one: 6c6ddf9#diff-67e997bcfdac55191033d57a16d1408aR3434. Maybe the HAVE_POSIX_SPAWN define in posixmodule.c is not necessary?

configure checks for posix_spawn() availability but then posixmodule.c defines "#define HAVE_POSIX_SPAWN 1"? I'm not sure that "#define HAVE_POSIX_SPAWN 1" makes sense. Would you like to propose a patch to remove this #define?

I merged your PR to get a working Python 3.7beta1 on Android. I suggest to wait after the beta1 to revisit (remove) the #define.

@pablogsal

Copy link
Copy Markdown
Member

@vstinner The removal for "#define HAVE_POSIX_SPAWN 1" is being done in #5418

@yan12125 yan12125 deleted the android-no-posix-spawn branch January 29, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants