{{ message }}
bpo-31368: Enhance os.preadv() documentation#5415
Closed
vstinner wants to merge 5 commits into
Closed
Conversation
Member
Sorry, something went wrong.
csabella
reviewed
Jan 29, 2018
pablogsal
requested changes
Jan 29, 2018
pread(): rename second parameter from 'buffersize' to 'n', reuse read() parameter name. The parameter is positional-only and so this change is backward compatible.
Member
Author
|
Sorry for reviewers, but I basically rewrote my whole PR to cleanup the documentation of all read and write functions:
The documentation should now be more consistent. |
Sorry, something went wrong.
YoSTEALTH
suggested changes
Jan 29, 2018
vadmium
reviewed
Jan 30, 2018
Member
Author
|
I abandon my change. Feel free to reuse my change to create a new PR if you want to enhance the documentation. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue31368