◐ Shell
reader mode source ↗
Skip to content

bpo-20104: Fix memory leaks and error handling in posix spawn#5418

Merged
gpshead merged 9 commits into
python:masterfrom
pablogsal:bpo20104
Jan 29, 2018
Merged

bpo-20104: Fix memory leaks and error handling in posix spawn#5418
gpshead merged 9 commits into
python:masterfrom
pablogsal:bpo20104

Conversation

@pablogsal

@pablogsal pablogsal commented Jan 29, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal

pablogsal commented Jan 29, 2018

Copy link
Copy Markdown
Member Author

CC: @vadmium @gpshead

@pablogsal pablogsal force-pushed the bpo20104 branch 2 times, most recently from 2512695 to cb74d14 Compare January 29, 2018 10:14
@pablogsal

pablogsal commented Jan 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@vadmium There was a missing commit due to a failed push. I have amended the last commit to including all the fixes. In cb74d14 you will find the correct initial implementation. Sorry for the confusion.

@pablogsal pablogsal mentioned this pull request Jan 29, 2018
Merged
@pablogsal

pablogsal commented Jan 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@vstinner Can you take a general look at this PR (if you have the time) to check that we are not missing something else? (The Docs are not included in this PR)

gpshead
gpshead requested changes Jan 29, 2018
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

thanks for the cleanup!

@bedevere-bot

bedevere-bot commented Jan 29, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@gpshead gpshead added skip news type-bug An unexpected behavior, bug, or error labels Jan 29, 2018
@pablogsal

pablogsal commented Jan 29, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 29, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@gpshead gpshead merged commit 0cd6bca into python:master Jan 29, 2018
@pablogsal pablogsal deleted the bpo20104 branch January 29, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise left review comments

@vadmium vadmium vadmium left review comments

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @bedevere-bot @matrixise @gpshead @vadmium @the-knights-who-say-ni