◐ Shell
reader mode source ↗
Skip to content

bpo-29248: Fix readlink bug os#5577

Merged
berkerpeksag merged 8 commits into
python:masterfrom
SSE4:fix-issue-29248
Feb 12, 2018
Merged

bpo-29248: Fix readlink bug os#5577
berkerpeksag merged 8 commits into
python:masterfrom
SSE4:fix-issue-29248

Conversation

@SSE4

@SSE4 SSE4 commented Feb 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

see https://bugs.python.org/issue29248

a year already has passed since patch was provided. what should be done to make this into python release?

/cc @gvanrossum @berkerpeksag @asvetlov

https://bugs.python.org/issue29248

@SSE4
bpo-29248: Fix readlink bug os …
2cb8ba6 
Signed-off-by: SSE4 <tomskside@gmail.com>
@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 7, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@SSE4
add Misc/NEWS.d entry …
3c8ce39 
Signed-off-by: SSE4 <tomskside@gmail.com>
gvanrossum
gvanrossum reviewed Feb 7, 2018
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Otherwise looks good.

@berkerpeksag

berkerpeksag commented Feb 7, 2018

Copy link
Copy Markdown
Member

@SSE4 please let us know when you sign the CLA form so we can merge this PR.

@SSE4

SSE4 commented Feb 7, 2018

Copy link
Copy Markdown
Contributor Author

@berkerpeksag I already did earlier today

@SSE4

SSE4 commented Feb 9, 2018

Copy link
Copy Markdown
Contributor Author

/cc @DinoV @zooba can please take a look at this issue related to Microsoft Windows?

berkerpeksag
berkerpeksag approved these changes Feb 9, 2018
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

All review comments have been addressed and this looks good to me. I will wait for a day or two to give everyone a chance to look at the patch and merge it. Thanks!

@SSE4

SSE4 commented Feb 12, 2018

Copy link
Copy Markdown
Contributor Author

@berkerpeksag okay, 3 days passed already, what's the next action to be done?

@berkerpeksag berkerpeksag merged commit 3c34aad into python:master Feb 12, 2018
@miss-islington

miss-islington commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @SSE4 for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 12, 2018

Copy link
Copy Markdown

GH-5640 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2018
@SSE4 @miss-islington
bpo-29248: Fix os.readlink() on Windows (pythonGH-5577) …
1dfe7a7 
The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.
(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 <tomskside@gmail.com>
berkerpeksag pushed a commit that referenced this pull request Feb 12, 2018
@miss-islington @SSE4 @berkerpeksag
bpo-29248: Fix os.readlink() on Windows (GH-5577) …
a1d33f7 
The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.

(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 <tomskside@gmail.com>
@berkerpeksag

berkerpeksag commented Feb 12, 2018

Copy link
Copy Markdown
Member

@Mariatta do I need to backport this to 3.7 branch manually or is there some sort of queue?

@miss-islington

miss-islington commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @SSE4 for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 12, 2018

Copy link
Copy Markdown

GH-5644 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2018
@SSE4 @miss-islington
bpo-29248: Fix os.readlink() on Windows (pythonGH-5577) …
e6a1b8d 
The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.
(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 <tomskside@gmail.com>
@Mariatta

Mariatta commented Feb 12, 2018

Copy link
Copy Markdown
Member

@berkerpeksag I think this was merged at the same time miss-islington was being deployed, so it missed that webhook event. I've reapplied the label to trigger the backport.

@berkerpeksag

berkerpeksag commented Feb 12, 2018

Copy link
Copy Markdown
Member

@Mariatta thanks!

miss-islington added a commit that referenced this pull request Feb 12, 2018
@miss-islington @SSE4
bpo-29248: Fix os.readlink() on Windows (GH-5577) …
74ebbae 
The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.
(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 mentioned this pull request Feb 13, 2018
Closed
3 tasks
@merwok merwok changed the title bpo-29248: Fix readlink bug os Feb 18, 2018
@merwok merwok changed the title s/merwokbpo-29248: Fix readlink bug os Feb 18, 2018
@merwok

merwok commented Feb 18, 2018

Copy link
Copy Markdown
Member

@berkerpeksag I noticed that the news file is the only one in the repo to use CRLF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

@gvanrossum gvanrossum gvanrossum left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@SSE4 @the-knights-who-say-ni @berkerpeksag @miss-islington @bedevere-bot @Mariatta @merwok @eryksun @gvanrossum @serhiy-storchaka