WIP: bpo-1100942: Add datetime.time.strptime and datetime.date.strptime#5578

matrixise

Add datetime.date.strptime and datetime.time.strptime.

Fix the documentation of _strptime._strptime, the documentation was
wrong, return a 3-tuple and not a 2-tuple

Co-authored-by: Alexander Belopolsky alexander.belopolsky@gmail.com
Co-authored-by: Amaury Forgeot d'Arc amauryfa@gmail.com
Co-authored-by: Berker Peksag berker.peksag@gmail.com
Co-authored-by: Josh-sf josh-sf@users.sourceforge.net
Co-authored-by: Juarez Bochi jbochi@gmail.com
Co-authored-by: Maciej Szulik soltysh@gmail.com
Co-authored-by: Stéphane Wirtel stephane@wirtel.be
Co-authored-by: Matheus Vieira Portela matheus.v.portela@gmail.com

https://bugs.python.org/issue1100942

matrixise

This PR is for a very long issue, since 2005. We have a PR in 2018 👍

Mariatta

I restarted the travis job. It still did not do the full CPython test suite. So please rebase :)

matrixise

Thanks, I didn't see your message, works on this issue today.

matrixise

@Mariatta rebased and the tests pass on the CIs

matrixise

Hi @pganssle

thank you for your review, I am going to fix it asap but I am not the author of the code, just the author of the PR. so, maybe I would need your help. Thanks

matrixise

@pganssle I just rebased my branch with master. I am going to work on this PR. Do you want to help me because you are mister dateutil ;-)

pganssle

@matrixise Sorry this is on my list but probably can't get to it until the end of the month. 😟

matrixise

@pganssle ok, in this case, I will try to fix all the issues alone ;-) but I am not worried ;-)

matrixise

Hi, I just updated this PR with master.

matrixise

@pganssle when you have time, could you review this PR, we started together, just comment when you find a mistake, thanks

matrixise

ping @pganssle ;-)

pganssle

I haven't had a chance to look at the PR thoroughly, but I have a first-pass review of things that should be changed.

I also haven't checked exactly how you are doing it, but I believe we may want to / be able to refactor the tests a bit to take advantage of the existing test suite for datetime.strptime by separating out the date-only and time-only formats and reusing the tests with date, time and datetime.

Additionally, I should note that it's unfortunate that if this is merged, we'll have time.strptime and datetime.time.strptime, the first of which returns a timetuple (which is actually more like a datetime), and the second returning a datetime.time object. I don't see any way around this, but it will add confusion. :(

matrixise

@pganssle thanks for your review, I am going to update this PR asap.

matrixise

ok, rebased with the last master.

matrixise

ok, I will check and try to fix that, but because I don't know this part and the main patch was not mine, that will be difficult. but okay for the fix. thanks for the review.

matrixise

@pganssle Are you ready for a new review of this PR? I will continue my PR ;-)

vadmium

I suggest you check the discussion about the previous patches. I noticed I repeated some old comments and ideas.

list

csabella

@matrixise, @pganssle There's been a lot of work done on this one. Is it something we should try to move forward on? Thanks!

github-actions

This PR is stale because it has been open for 30 days with no activity.

zitterbewegung

@matrixise, @pganssle, @csabella while there has been lots of work for this where are we at on this? Its around a bit over two years old for the PR but, these new features would be great!

vstinner

where are we at on this?

No activity since 2019. Someone has to step in and restart the work (ex: create a new PR and update the PR).

nineteendo

I'm going to try to resolve the merge conflicts and make the requested changes.

nineteendo

Looks like I'll have to start over.

vstinner

I close the inactive PR.

the-knights-who-say-ni added the CLA signed label Feb 7, 2018

bedevere-bot added the awaiting review label Feb 7, 2018

matrixise mentioned this pull request Feb 7, 2018

Travis has an issue with the C build? python/core-workflow#218

Closed

matrixise force-pushed the bpo-1100942 branch from ad32c42 to a7b624a Compare February 15, 2018 08:23

pganssle reviewed May 15, 2018

View reviewed changes

pganssle requested changes May 15, 2018

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 15, 2018

matrixise force-pushed the bpo-1100942 branch from fb6d098 to 1d7a5b0 Compare October 5, 2018 16:01

matrixise force-pushed the bpo-1100942 branch from 1d7a5b0 to c286708 Compare October 17, 2018 19:56

matrixise force-pushed the bpo-1100942 branch from a6722e7 to 7526de9 Compare October 25, 2018 14:02

pganssle requested changes Nov 4, 2018

View reviewed changes

matrixise force-pushed the bpo-1100942 branch from 1ca284e to 43a77af Compare November 11, 2018 14:15

matrixise added 10 commits March 22, 2019 18:16

Fix the signatures

010ac8b

Update with the recommendation of @pganssle

5b58fc1

Update

8353a65

Add use case where we generate an exception

cff74a9

Add the Py_UNUSED(ignore) for datetime_gettime & datetime_getdate

f92a799

Add a link to the strtime() and strptime() behaviour

4c4a7cc

Update the blurb entry and add an entry in the Doc/whatsnew/3.8.rst

b006172

Fix doc

ff7487f

Convert the _check_invalid_datetime_spec to the C-API

a048f0e

Support tuple and list for the specs

9ac0af4

matrixise force-pushed the bpo-1100942 branch from 70c125f to 9ac0af4 Compare March 22, 2019 17:17

vadmium reviewed Mar 23, 2019

View reviewed changes

matrixise changed the title ~~bpo-1100942: Add datetime.time.strptime and datetime.date.strptime~~ Mar 24, 2019

matrixise added 2 commits March 24, 2019 14:20

_datetimemodule._check_invalid_datetime_specs only accepts tuple and not …

a952bb7

list

Fix the code with the recommendation of Martin Panter

412aea2

josh-sf mannequin mentioned this pull request Apr 9, 2022

Add datetime.time.strptime and datetime.date.strptime #41431

Closed

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 15, 2022

abalkin marked this pull request as draft February 8, 2023 14:59

abalkin self-assigned this Feb 8, 2023

abalkin linked an issue Feb 8, 2023 that may be closed by this pull request

Add datetime.time.strptime and datetime.date.strptime #41431

Closed

github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 1, 2023

vstinner closed this Jun 19, 2024

Conversation

matrixise commented Feb 7, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matrixise commented Feb 7, 2018

Uh oh!

Mariatta commented Feb 9, 2018

Uh oh!

matrixise commented Feb 15, 2018

Uh oh!

matrixise commented Feb 15, 2018

Uh oh!

matrixise commented May 15, 2018

Uh oh!

matrixise commented Oct 5, 2018

Uh oh!

pganssle commented Oct 5, 2018

Uh oh!

matrixise commented Oct 5, 2018

Uh oh!

matrixise commented Oct 17, 2018

Uh oh!

matrixise commented Oct 25, 2018

Uh oh!

matrixise commented Nov 4, 2018

Uh oh!

pganssle left a comment

Choose a reason for hiding this comment

Uh oh!

matrixise commented Nov 4, 2018

Uh oh!

matrixise commented Nov 11, 2018

Uh oh!

matrixise commented Nov 11, 2018 via email

Uh oh!

matrixise commented Feb 20, 2019

Uh oh!

vadmium left a comment

Choose a reason for hiding this comment

Uh oh!

csabella commented Nov 16, 2019

Uh oh!

github-actions Bot commented Aug 15, 2022

Uh oh!

zitterbewegung commented May 23, 2024

Uh oh!

vstinner commented May 23, 2024

Uh oh!

nineteendo commented Jun 18, 2024

Uh oh!

nineteendo commented Jun 19, 2024

Uh oh!

vstinner commented Jun 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

matrixise commented Feb 7, 2018 •

edited by bedevere-bot

Loading