◐ Shell
reader mode source ↗
Skip to content

bpo-32831: IDLE: Add docstrings and tests for codecontext#5638

Merged
terryjreedy merged 6 commits into
python:masterfrom
csabella:codecontext
May 19, 2018
Merged

bpo-32831: IDLE: Add docstrings and tests for codecontext#5638
terryjreedy merged 6 commits into
python:masterfrom
csabella:codecontext

Conversation

@csabella

@csabella csabella commented Feb 12, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@terryjreedy

terryjreedy commented May 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

I have updated to current upstream. Tests pass. I am reviewing and making minor changes.

terryjreedy
terryjreedy approved these changes May 17, 2018
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

With the changes I made (mostly to the two longest docstrings), I think this is ready to merge. You can look at my changes first, and do a last check, but I want to merge in a day or two so this gets into 3.7.0rc1.

@terryjreedy

terryjreedy commented May 18, 2018

Copy link
Copy Markdown
Member

Given that the CI bots have become merge roadblocks, I don't want to touch this unless a change is non-trivial.

@terryjreedy terryjreedy merged commit 654038d into python:master May 19, 2018
@miss-islington

miss-islington commented May 19, 2018

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2018
@csabella @miss-islington
bpo-32831: IDLE: Add docstrings and tests for codecontext (pythonGH-5638 …
791ebe5 
)

(cherry picked from commit 654038d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented May 19, 2018

Copy link
Copy Markdown

GH-6988 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2018
@csabella @miss-islington
bpo-32831: IDLE: Add docstrings and tests for codecontext (pythonGH-5638 …
d2f80e3 
)

(cherry picked from commit 654038d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented May 19, 2018

Copy link
Copy Markdown

GH-6989 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 19, 2018
@miss-islington @csabella
bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638) …
83aedc4 
(cherry picked from commit 654038d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request May 19, 2018
@miss-islington @csabella
bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638) …
0efa135 
(cherry picked from commit 654038d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the codecontext branch May 19, 2018 21:22
@csabella

csabella commented May 19, 2018

Copy link
Copy Markdown
Contributor Author

@terryjreedy, thanks for the merge. Sorry I didn't get to address your questions before you committed the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csabella @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni