bpo-32839: Add after_info to tkinter#5664
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
I pushed a rebase and got the Appveyor error. I'm working on the other concerns about the |
Sorry, something went wrong.
|
Cheryl, can you explain the closing? I still think adding after_info would be good. |
Sorry, something went wrong.
|
The only reported error, only on Travis, on line 191 is an extra item, 'after#8' (the 'timer' of line 180, I presume), in the tuple returned from .after_info. (The Travis job page somehow disables copying with current Firefox.) On this system, with the tcl/tk used, the preceding root.update() did not remove the 'timer' callback from the list. I restarted the failing job to see if the failure is repeatable on Travis. Answer: yes. |
Sorry, something went wrong.
|
FWIW, I also think adding |
Sorry, something went wrong.
|
Sorry about closing this prematurely. I had thought there hadn't been much interest in adding the functionality when I originally proposed it, so I was just doing some housekeeping. Good to know there is interest. Having said that, the tests pass locally, so it may be tricky to get them to pass. I have a |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please expand the NEWS entry, add a What's New entry apply and test the code suggestion.
The PR looks mostly good to me and I want to land it in 3.9.
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This reverts commit 5b33773.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I expanded the NEWS entry and added the What's New entry. My last code suggestions turned out to be wrong.
LGTM.
Sorry, something went wrong.
|
I am presuming that my old comments are obsolete. |
Sorry, something went wrong.
https://bugs.python.org/issue32839