◐ Shell
reader mode source ↗
Skip to content

bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements#570

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
orenmn:bpo28298-make-array-accept-big-intables
Mar 9, 2017
Merged

bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements#570
serhiy-storchaka merged 3 commits into
python:masterfrom
orenmn:bpo28298-make-array-accept-big-intables

Conversation

@orenmn

@orenmn orenmn commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

according to http://bugs.python.org/issue28298:

  • make array 'Q', 'L' and 'I' accept big intables (objects that have __int__) as elements
  • add to test_array tests to verify this change, and tests to verify that int types arrays don't accept floats as elements
  • while we are in test_array, remove checks whether long long is available

(I ran the test module again, and on my Windows 10, the same tests failed with
and without my patches. However, on my Ubuntu 16.04 VM, none of the tests
failed.)

@mention-bot

Copy link
Copy Markdown

@orenmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @serhiy-storchaka, @vadmium, @doerwalter and @Yhg1s to be potential reviewers.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.5 labels Mar 9, 2017

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Add an entry in Misc/NEWS.

@serhiy-storchaka serhiy-storchaka merged commit 964281a into python:master Mar 9, 2017
serhiy-storchaka added a commit that referenced this pull request Mar 9, 2017
@serhiy-storchaka

Copy link
Copy Markdown
Member

Oh, I reverted just merged commit! How to restore it back?

@serhiy-storchaka

Copy link
Copy Markdown
Member

It was not merged into master. Don't worry.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@1.7.1...1.7.2)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants