◐ Shell
reader mode source ↗
Skip to content

bpo-32857: tkinter after_cancel to raise error if called with None#5701

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
csabella:bpo32857
Mar 4, 2018
Merged

bpo-32857: tkinter after_cancel to raise error if called with None#5701
serhiy-storchaka merged 4 commits into
python:masterfrom
csabella:bpo32857

Conversation

@csabella

@csabella csabella commented Feb 16, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Feb 20, 2018
@serhiy-storchaka serhiy-storchaka merged commit 74382a3 into python:master Mar 4, 2018
@miss-islington

miss-islington commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2018
@csabella @miss-islington
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
262c137 
…e. (pythonGH-5701)

(cherry picked from commit 74382a3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Mar 4, 2018

Copy link
Copy Markdown

GH-5972 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Sorry, @csabella and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 74382a3f175ac285cc924a73fd758e8dc3cc41bb 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2018
@csabella @miss-islington
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
9c2ed48 
…e. (pythonGH-5701)

(cherry picked from commit 74382a3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Mar 4, 2018

Copy link
Copy Markdown

GH-5973 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 4, 2018
@miss-islington @csabella
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
73a4396 
…e. (GH-5701)

(cherry picked from commit 74382a3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Mar 4, 2018
@miss-islington @csabella
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
a5303dd 
…e. (GH-5701)

(cherry picked from commit 74382a3)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the bpo32857 branch March 4, 2018 12:54
@csabella

csabella commented Mar 4, 2018

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Would you like me to cherry pick this to 2.7?

@serhiy-storchaka

serhiy-storchaka commented Apr 18, 2018

Copy link
Copy Markdown
Member

Yes, it would be nice.

csabella added a commit to csabella/cpython that referenced this pull request Apr 27, 2018
@csabella
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
aeabb7a 
…e. (pythonGH-5701)

(cherry picked from commit 74382a3)
@bedevere-bot

bedevere-bot commented Apr 27, 2018

Copy link
Copy Markdown

GH-6620 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request May 5, 2018
@csabella @serhiy-storchaka
bpo-32857: Raise error when tkinter after_cancel() is called with Non… …
3a04598 
…e. (GH-5701) (GH-6620)

(cherry picked from commit 74382a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csabella @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni