◐ Shell
reader mode source ↗
Skip to content

[3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-5726)#5747

Merged
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-08a6926-3.6
Feb 19, 2018
Merged

[3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-5726)#5747
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-08a6926-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 18, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 08a6926)

Co-authored-by: Éric Araujo merwok@netwok.org

https://bugs.python.org/issue21060

@merwok @miss-islington
Improve error message for "setup.py upload" without dist files (pytho… …
119ed68 
…nGH-21060)

(cherry picked from commit 08a6926)

Co-authored-by: Éric Araujo <merwok@netwok.org>
@Mariatta

Mariatta commented Feb 19, 2018

Copy link
Copy Markdown
Member

The commit message was wrong: It should be include bpo-21060 and the original PR number GH-5726. Please update that too for the other backport PRs.

@Mariatta Mariatta mentioned this pull request Feb 19, 2018
Closed
@merwok

merwok commented Feb 19, 2018

Copy link
Copy Markdown
Member

Ok! I thought the new bpo-nnn style was recommended but the older shorter style #NNN still working.

@merwok merwok changed the title [3.6] Improve error message for "setup.py upload" without dist files (GH-21060) Feb 19, 2018
@Mariatta

Mariatta commented Feb 19, 2018

Copy link
Copy Markdown
Member

That old style works in bpo but not in GitHub :)

@merwok

merwok commented Feb 19, 2018

Copy link
Copy Markdown
Member

Yes I don’t expect github to create links to bpo but custom bots could do what they want.

I prefer bug tracker-neutral references like «#1234» that humans understand over site-specific «sf1234» or the ugly «issue1234». Also I used to try to keep the first line of commit logs short! But next time I’ll follow what works with the bots.

@Mariatta Mariatta changed the title [3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-21060) Feb 19, 2018
@bedevere-bot bedevere-bot mentioned this pull request Feb 19, 2018
Merged
@miss-islington

miss-islington commented Feb 19, 2018

Copy link
Copy Markdown
Contributor Author

@merwok: Backport status check is done, and it's a failure ❌ .

@Mariatta

Mariatta commented Feb 19, 2018

Copy link
Copy Markdown
Member

PR title fixed. It needs to reference the PR on master, so bedevere can properly remove the label.

@miss-islington

miss-islington commented Feb 19, 2018

Copy link
Copy Markdown
Contributor Author

@merwok: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2a93fae into python:3.6 Feb 19, 2018
@miss-islington

miss-islington commented Feb 19, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-08a6926-3.6 branch February 19, 2018 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @Mariatta @merwok @the-knights-who-say-ni @bedevere-bot