◐ Shell
reader mode source ↗
Skip to content

bpo-33015: Add a wrapper for thread function in PyThread_start_new_thread#6008

Merged
vstinner merged 4 commits into
python:masterfrom
siddhesh:pthread-func-warn
Nov 30, 2018
Merged

bpo-33015: Add a wrapper for thread function in PyThread_start_new_thread#6008
vstinner merged 4 commits into
python:masterfrom
siddhesh:pthread-func-warn

Conversation

@siddhesh

@siddhesh siddhesh commented Mar 6, 2018 •
edited by methane
Loading

Copy link
Copy Markdown
Contributor

PyThread_start_new_thread accepts a function of type void (*) (void *), which does not match with the pthread_create function callback prototype void *(*) (void *). This results in an invalid function cast warning with gcc8. Fix this by wrapping the function in an internal pthread function callback that returns NULL.

https://bugs.python.org/issue33015

@bedevere-bot bedevere-bot added the label Mar 6, 2018
izbyshev
izbyshev suggested changes Mar 10, 2018
View reviewed changes

@izbyshev izbyshev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Good bar cosmetic issues and a leak.

@siddhesh

siddhesh commented Apr 22, 2018

Copy link
Copy Markdown
Contributor Author

Hi, any update on this PR?

izbyshev
izbyshev approved these changes Apr 22, 2018
View reviewed changes

@izbyshev izbyshev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I wasn't aware of your changes because I didn't receive any notifications from github for some reason. LGTM now, thank you! Still needs an approval from a core dev.

@siddhesh

siddhesh commented Jun 13, 2018

Copy link
Copy Markdown
Contributor Author

Hello, any update on this?

@siddhesh

siddhesh commented Jul 3, 2018

Copy link
Copy Markdown
Contributor Author

Hello, Ping!

@izbyshev

izbyshev commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

@zooba Would you look at this PR?

zooba
zooba approved these changes Aug 23, 2018
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks fine to me.

@izbyshev

izbyshev commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

@zooba Thank you!
@siddhesh Nit: would be nice to reformat the NEWS entry to fit in 80 columns (blurb does that automatically).

@siddhesh

siddhesh commented Aug 24, 2018

Copy link
Copy Markdown
Contributor Author

Done, I also fixed up the dates for the change.

@vstinner

vstinner commented Oct 23, 2018

Copy link
Copy Markdown
Member

See also PR #6748 and https://bugs.python.org/issue33012

@vstinner vstinner mentioned this pull request Oct 23, 2018
Merged
vstinner
vstinner requested changes Oct 23, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The change looks valid, but I need to be convinced that a compiler warning justify a memory allocation just to call a function.

@bedevere-bot

bedevere-bot commented Oct 23, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pitrou
pitrou requested changes Oct 23, 2018
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good on the principle, just two minor comments.

@gpshead

gpshead commented Oct 24, 2018

Copy link
Copy Markdown
Member

Based on conversations with C / C++ experts at work, this approach seems correct (one even came up with an effectively identical proposal).

Yes, it is unfortunate that we're in this situation due to the mismatched PyThread_start_new_thread API vs pthread_create when the ABIs and compilers on the common platforms today have so far resulted in the existing implicit cast's undefined behavior just happening to work fine, but this implementation is actually correct.

I agree with @pitrou 's code review comments.

@pitrou

pitrou commented Oct 25, 2018

Copy link
Copy Markdown
Member

This looks good to me. I will let other people comment just in case, otherwise merge soon.

27 hidden items Load more…
siddhesh and others added 3 commits November 30, 2018 14:28
@siddhesh @vstinner
Add a wrapper for thread function in PyThread_start_new_thread …
d3a9724 
PyThread_start_new_thread accepts a function of type void (*) (void
*), which does not match with the pthread_create function callback
prototype void *(*) (void *).  This is undefined behaviour and hence
results in an invalid function cast warning with gcc8.  Fix this by
wrapping the function in an internal pthread function callback that
returns NULL.
@vstinner
Cleanup code …
4d5b9b0 
* Rename pythread_fn to pythread_callback
* Rename pythread_helper_fn() to pythread_wrapper()
* Rewrite the comment
@vstinner
More cleanup …
6d0bade 
* Rename "fn" to "callback"
* Add { ... } to if
* Remove useless cast
@vstinner

vstinner commented Nov 30, 2018

Copy link
Copy Markdown
Member

Since @siddhesh didn't reply since one month, I took the liberty of rebasing his change and apply my proposed cleanup changes.

vstinner
vstinner approved these changes Nov 30, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@siddhesh

siddhesh commented Nov 30, 2018

Copy link
Copy Markdown
Contributor Author

Sorry about that, I've been tied up and hence couldn't get to this. Thanks for cleaning it up for me.

@vstinner vstinner merged commit 9eea6ea into python:master Nov 30, 2018
@miss-islington

miss-islington commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Thanks @siddhesh for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 30, 2018
@siddhesh @miss-islington
bpo-33015: Fix UB in pthread PyThread_start_new_thread (pythonGH-6008) …
fb6feaa 
Fix an undefined behaviour in the pthread implementation of
PyThread_start_new_thread(): add a function wrapper to always return
NULL.

Add pythread_callback struct and pythread_wrapper() to thread_pthread.h.
(cherry picked from commit 9eea6ea)

Co-authored-by: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 30, 2018

Copy link
Copy Markdown

GH-10821 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Sorry, @siddhesh and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9eea6eaf23067880f4af3a130e3f67c9812e2f30 3.6

@miss-islington

miss-islington commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Sorry, @siddhesh and @vstinner, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9eea6eaf23067880f4af3a130e3f67c9812e2f30 2.7

@bedevere-bot

bedevere-bot commented Nov 30, 2018

Copy link
Copy Markdown

GH-10822 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

bedevere-bot commented Nov 30, 2018

Copy link
Copy Markdown

GH-10823 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Nov 30, 2018
@miss-islington @siddhesh
bpo-33015: Fix UB in pthread PyThread_start_new_thread (GH-6008) …
b135535 
Fix an undefined behaviour in the pthread implementation of
PyThread_start_new_thread(): add a function wrapper to always return
NULL.

Add pythread_callback struct and pythread_wrapper() to thread_pthread.h.
(cherry picked from commit 9eea6ea)

Co-authored-by: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
vstinner added a commit that referenced this pull request Nov 30, 2018
@vstinner
bpo-33015: Fix UB in pthread PyThread_start_new_thread (GH-6008) (GH-… …
03b1200 
…10822)

Fix an undefined behaviour in the pthread implementation of
PyThread_start_new_thread(): add a function wrapper to always return
NULL.

Add pythread_callback struct and pythread_wrapper() to thread_pthread.h.

(cherry picked from commit 9eea6ea)
vstinner added a commit that referenced this pull request Nov 30, 2018
@vstinner
bpo-33015: Fix UB in pthread PyThread_start_new_thread (GH-6008) (GH-… …
8f83c2f 
…10823)

Fix an undefined behaviour in the pthread implementation of
PyThread_start_new_thread(): add a function wrapper to always return
NULL.

Add pythread_callback struct and pythread_wrapper() to thread_pthread.h.

(cherry picked from commit 9eea6ea)
@bedevere-bot

bedevere-bot commented Nov 30, 2018

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian PGO 3.7 has failed when building commit b135535.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/128/builds/828) and take a look at the build logs.
  4. Check if the failure is related to this commit (b135535) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/128/builds/828

Click to see traceback logs 
From https://github.com/python/cpython
 * branch                  3.7        -> FETCH_HEAD
Reset branch '3.7'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [clean] Error 1 (ignored)
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
Task was destroyed but it is pending!
task: <Task pending coro=<<async_generator_athrow without __name__>()>>
Task was destroyed but it is pending!
task: <Task pending coro=<<async_generator_athrow without __name__>()>>
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
stty: 'standard input': Inappropriate ioctl for device
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
unhandled exception during asyncio.run() shutdown
task: <Task finished coro=<<async_generator_athrow without __name__>()> exception=RuntimeError("can't send non-None value to a just-started coroutine")>
RuntimeError: can't send non-None value to a just-started coroutine
unhandled exception during asyncio.run() shutdown
task: <Task finished coro=<<async_generator_athrow without __name__>()> exception=RuntimeError("can't send non-None value to a just-started coroutine")>
RuntimeError: can't send non-None value to a just-started coroutine
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.7.gps-debian-profile-opt.nondebug/build/Python/getargs.gcda:Merge mismatch for function 12
Python/getargs.c: In function ‘vgetargskeywords’:
Python/getargs.c:2551:1: internal compiler error: in create_edge, at cgraph.c:850
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
make[1]: *** [Python/getargs.o] Error 1
make: *** [profile-opt] Error 2

@bedevere-bot

bedevere-bot commented Nov 30, 2018

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64 Fedora 2.7 has failed when building commit 8f83c2f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/81/builds/295) and take a look at the build logs.
  4. Check if the failure is related to this commit (8f83c2f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/81/builds/295

Click to see traceback logs 
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib64/python2.7/test/test_support.py", line 22, in <module>
    import _testcapi
ImportError: No module named _testcapi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@zooba zooba zooba approved these changes

@pitrou pitrou pitrou approved these changes

+1 more reviewer

@izbyshev izbyshev izbyshev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@siddhesh @izbyshev @vstinner @bedevere-bot @gpshead @pitrou @miss-islington @zooba @the-knights-who-say-ni