◐ Shell
reader mode source ↗
Skip to content

bpo-27200: fix several doctests#604

Merged
berkerpeksag merged 13 commits into
python:masterfrom
marco-buttu:fix-issue-27200-3rd
Apr 27, 2017
Merged

bpo-27200: fix several doctests#604
berkerpeksag merged 13 commits into
python:masterfrom
marco-buttu:fix-issue-27200-3rd

Conversation

@marco-buttu

@marco-buttu marco-buttu commented Mar 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR partially fixes bpo-27200. Partially and not completely, because I followed the suggestion of @ezio-melotti to split the patch in several patches. This PR is the 3rd of the series. The first one was #240 and the second one #401.

To run the doctests (from the Doc directory):

$ sphinx-build -b doctest . build/doctest \
library/urllib.parse.rst \
library/functions.rst \
library/ipaddress.rst \
library/reprlib.rst \
library/shlex.rst \
library/email.compat32-message.rst \
whatsnew/3.2.rst

@mention-bot

mention-bot commented Mar 10, 2017

Copy link
Copy Markdown

@marco-buttu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @eliben, @birkenfeld, @vsajip and @bitdancer to be potential reviewers.

bitdancer
bitdancer requested changes Mar 10, 2017
View reviewed changes

@bitdancer bitdancer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I've only glanced at the non-email package stuff, and I haven't tested any of it myself, but this looks reasonable except for my one comment.

@marco-buttu marco-buttu mentioned this pull request Mar 11, 2017
Merged
@marco-buttu marco-buttu mentioned this pull request Mar 26, 2017
Closed
@berkerpeksag

berkerpeksag commented Apr 26, 2017

Copy link
Copy Markdown
Member

Thanks, Marco. I'll wait for @bitdancer's approval since he requested changes to the PR earlier.

@berkerpeksag berkerpeksag merged commit e65fcde into python:master Apr 27, 2017
@berkerpeksag

berkerpeksag commented Apr 27, 2017

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marco-buttu @mention-bot @berkerpeksag @bitdancer @the-knights-who-say-ni