[3.6] bpo-31639: Use threads in http.server module. (GH-5018)#6203
[3.6] bpo-31639: Use threads in http.server module. (GH-5018)#6203miss-islington wants to merge 1 commit into
Conversation
(cherry picked from commit 8bcfa02) Co-authored-by: Julien Palard <julien@palard.fr>
|
@JulienPalard: Backport status check is done, and it's a success ✅ . |
Sorry, something went wrong.
ned-deily
left a comment
There was a problem hiding this comment.
+0 I'm not sure that is appropriate for 3.6.x at this stage but I'm willing to be persuaded. BTW, I believe all of the comments apply to the 3.7 and master versions of the changes. I'm too lazy to duplicate.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
@ned-deily thanks for the feedback. I think it's ok for 3.6 (not as a language bug fix I agree, but as a usability fix): I encontered the issue multiple time by using "python3 -m http.server", typically to test the doc. I expect other people to find the bug too. |
Sorry, something went wrong.
|
OK, I guess this is OK for 3.6. If you want to address some or all of the comments in a follow-on PR for master and 3.7, that's fine. |
Sorry, something went wrong.
|
As discussed with @vstinner, I'll finally won't backport it to 3.6: introducing a new class (changing the API) is something we should not do. It's still fixable without changing the API by hiding the |
Sorry, something went wrong.
|
@JulienPalard @miss-islington Thanks for this PR. However what do you think about changing the class name
|
Sorry, something went wrong.
(cherry picked from commit 8bcfa02)
Co-authored-by: Julien Palard julien@palard.fr
https://bugs.python.org/issue31639