◐ Shell
reader mode source ↗
Skip to content

bpo-30940: Updating round() docs.#6342

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
lisroach:round_docs
May 20, 2018
Merged

bpo-30940: Updating round() docs.#6342
serhiy-storchaka merged 2 commits into
python:masterfrom
lisroach:round_docs

Conversation

@lisroach

@lisroach lisroach commented Apr 2, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Updating the round docs to make it more clear what happens when None is the second argument to round().

https://bugs.python.org/issue30940

@ned-deily ned-deily requested a review from mdickinson April 2, 2018 19:47
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir labels Apr 2, 2018
matrixise
matrixise approved these changes May 14, 2018
View reviewed changes

@matrixise matrixise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hi @lisroach, thank you for your PR, it's really appreciated and you have upgraded your PR with the recommendation of @serhiy-storchaka. Thank you.

@serhiy-storchaka

serhiy-storchaka commented May 14, 2018

Copy link
Copy Markdown
Member

@mdickinson, could you please make a look?

mdickinson
mdickinson approved these changes May 15, 2018
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@willingc

willingc commented May 19, 2018

Copy link
Copy Markdown
Contributor

@serhiy-storchaka Would you mind merging? I'm not confident that I have the backport process down yet. Thanks.

@serhiy-storchaka serhiy-storchaka merged commit 900c48d into python:master May 20, 2018
@miss-islington

miss-islington commented May 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @lisroach for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2018
@lisroach @miss-islington
bpo-30940: Updating round() docs. (pythonGH-6342) …
8a1522f 
(cherry picked from commit 900c48d)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
@bedevere-bot

bedevere-bot commented May 20, 2018

Copy link
Copy Markdown

GH-7009 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2018
@lisroach @miss-islington
bpo-30940: Updating round() docs. (pythonGH-6342) …
c744eea 
(cherry picked from commit 900c48d)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
@bedevere-bot

bedevere-bot commented May 20, 2018

Copy link
Copy Markdown

GH-7010 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka pushed a commit that referenced this pull request May 20, 2018
@miss-islington @lisroach @serhiy-storchaka
bpo-30940: Updating round() docs. (GH-6342) (GH-7009) …
736e3b3 
(cherry picked from commit 900c48d)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
@ned-deily ned-deily mentioned this pull request Jun 8, 2018
Closed
@ned-deily ned-deily mentioned this pull request Jun 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@matrixise matrixise matrixise approved these changes

+1 more reviewer

@mdickinson mdickinson

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@lisroach @serhiy-storchaka @willingc @miss-islington @bedevere-bot @matrixise @mdickinson @ned-deily @the-knights-who-say-ni