bpo-29534: _decimal difference with _pydecimal#65
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
The new behaviour seems like the right thing to me. Can you rework the code to avoid the repetition of the |
Sorry, something went wrong.
|
@mdickinson thanks for the comment! I've just reworked my PR to avoid code duplication. |
Sorry, something went wrong.
|
@mdickinson thanks! I've fixed all the nitpickings you mentioned. Also updated NEWS. |
Sorry, something went wrong.
|
@andrewnester: Thank you! One last nitpick: please could you change the name of the test? Apart from that, this looks good to go. Did you fill out the CLA? |
Sorry, something went wrong.
|
@mdickinson fixed. yes, I filled it couple of hours ago :) |
Sorry, something went wrong.
|
In, that case, LGTM unconditionally. |
Sorry, something went wrong.
mdickinson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350959 +11
==========================================
+ Hits 289095 289100 +5
- Misses 61853 61859 +6Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
The coverage gods seem a bit peeved, but I can't make head or tail of the coverage report. Which 6 lines are new misses? (And which 5 lines are new hits?) |
Sorry, something went wrong.
|
Merged. Thanks for the contribution! |
Sorry, something went wrong.
* refactor: return BB metadata from BB creation function * feat: add execute jitted code in BB_BRANCH * nit: disable JIT debug * nit: Removed debugging comment in ceval_macros.h * nit: Removed indirection warning in jit.py --------- Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
Fix for https://bugs.python.org/issue29534