{{ message }}
bpo-33305: Improve SyntaxError for invalid numerical literals.#6517
Merged
serhiy-storchaka merged 5 commits intoJul 9, 2018
Merged
Conversation
Member
Sorry, something went wrong.
serhiy-storchaka
added
type-feature
A feature request or enhancement
DO-NOT-MERGE
labels
Apr 18, 2018
SylvainDe
reviewed
Apr 19, 2018
SylvainDe
left a comment
SylvainDe
left a comment
Contributor
There was a problem hiding this comment.
This could be great.
Out of curiosity, would it make sense to add the character causing troubles in all cases ?
Sorry, something went wrong.
Member
Author
|
I'm going to merge this PR if there are no other suggestions. |
Sorry, something went wrong.
mdickinson
approved these changes
Jul 9, 2018
mdickinson
left a comment
mdickinson
left a comment
Member
There was a problem hiding this comment.
The new messages look great to me; I haven't reviewed the C code changes in detail.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue33305