◐ Shell
reader mode source ↗
Skip to content

bpo-28810: Update lnotab_notes.txt#665

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
ilevkivskyi:update-lnotab
Mar 14, 2017
Merged

bpo-28810: Update lnotab_notes.txt#665
serhiy-storchaka merged 3 commits into
python:masterfrom
ilevkivskyi:update-lnotab

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Mar 14, 2017

Copy link
Copy Markdown
Member

@serhiy-storchaka @brettcannon Here is the separate PR for lnotab_notes.txt that I promised.

This needs to be backported to 3.6.

@mention-bot

mention-bot commented Mar 14, 2017

Copy link
Copy Markdown

@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @avassalotti to be a potential reviewer.

@serhiy-storchaka

serhiy-storchaka commented Mar 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

The line

    255, 0, 45, 128, 0, 72.

doesn't look correct (the maximal line_incr is 127, not 128).

And while we are here please change "Python string" to "bytes object" (or "Python bytes object").

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir and removed cherry-pick for 3.6 labels Mar 14, 2017
@serhiy-storchaka

serhiy-storchaka commented Mar 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Ah, and while we are here, please fix tabs used instead of spaces.

@ilevkivskyi

ilevkivskyi commented Mar 14, 2017

Copy link
Copy Markdown
Member Author

@serhiy-storchaka

Ah, and while we are here, please fix tabs used instead of spaces.

Fixed. I have found only three lines with tabs in this file.

@serhiy-storchaka serhiy-storchaka merged commit 9135275 into python:master Mar 14, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 31, 2017
@ilevkivskyi @Mariatta
bpo-28810: Update lnotab_notes.txt (python#665) …
338a16e 
(cherry picked from commit 9135275)
@Mariatta Mariatta removed the label Mar 31, 2017
Mariatta added a commit that referenced this pull request Mar 31, 2017
@Mariatta
bpo-28810: Update lnotab_notes.txt (GH-665) (GH-919) …
0a17e58 
(cherry picked from commit 9135275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilevkivskyi @mention-bot @serhiy-storchaka @vstinner @Mariatta @the-knights-who-say-ni