{{ message }}
bpo-32769: Write annotation entry for glossary#6657
Merged
ilevkivskyi merged 8 commits intoMay 14, 2018
Merged
Conversation
Contributor
Sorry, something went wrong.
ilevkivskyi
reviewed
May 3, 2018
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks, looks good! I have just few minor comments.
Sorry, something went wrong.
ilevkivskyi
reviewed
May 3, 2018
ilevkivskyi
reviewed
May 3, 2018
Contributor
Author
|
@ilevkivskyi should I keep "class attributes" to refer to instance variables, or should I use the later to separate between data attributes (instance variables) and behavior attributes (methods)? I think "class attributes" is somewhat ambiguous. |
Sorry, something went wrong.
ilevkivskyi
approved these changes
May 14, 2018
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
I like how this looks now. Thanks!
Sorry, something went wrong.
andresdelfino
added a commit
to andresdelfino/cpython
that referenced
this pull request
May 14, 2018
https://bugs.python.org/issue32769 (cherry picked from commit f2290fb) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue32769