◐ Shell
reader mode source ↗
Skip to content

bpo-20104: Change the file_actions parameter of os.posix_spawn().#6725

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:posix_spawn-file_actions
Sep 8, 2018
Merged

bpo-20104: Change the file_actions parameter of os.posix_spawn().#6725
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:posix_spawn-file_actions

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 8, 2018

Copy link
Copy Markdown
Member
  • Make its default value an empty tuple instead of None.
  • Make it a keyword-only parameter.

https://bugs.python.org/issue20104

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM Do you want to wait until #6693 is merged to land this or you prefer to do it before?

@serhiy-storchaka

serhiy-storchaka commented Jul 29, 2018

Copy link
Copy Markdown
Member Author

It doesn't matter what PR will be merged first. But I want to wait for a review from any of other involved core devs: @benjaminp or @gpshead.

* Make its default value an empty tuple instead of None.
* Make it a keyword-only parameter.
@serhiy-storchaka serhiy-storchaka merged commit d700f97 into python:master Sep 8, 2018
@serhiy-storchaka serhiy-storchaka deleted the posix_spawn-file_actions branch September 8, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants