◐ Shell
reader mode source ↗
Skip to content

bpo-20104: Remove posix_spawn from 3.7#6794

Merged
gpshead merged 3 commits into
python:3.7from
pablogsal:remove_posix_spawn
May 14, 2018
Merged

bpo-20104: Remove posix_spawn from 3.7#6794
gpshead merged 3 commits into
python:3.7from
pablogsal:remove_posix_spawn

Conversation

@pablogsal

@pablogsal pablogsal commented May 14, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal changed the title bpo-20104: Remove posix_spawn in 3.7 May 14, 2018
@pablogsal pablogsal force-pushed the remove_posix_spawn branch 2 times, most recently from 3284174 to c200683 Compare May 14, 2018 15:10
@pablogsal

pablogsal commented May 14, 2018

Copy link
Copy Markdown
Member Author

CC: @gpshead

@pablogsal pablogsal force-pushed the remove_posix_spawn branch from c200683 to a65ef05 Compare May 14, 2018 16:01
gpshead
gpshead reviewed May 14, 2018
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

this looks straight forward.

I suggest dropping the changes to aclocal.m4, configure.ac, configure, pyconfig.h.in that remove the check for the API. It is fine for us to leave the autoconf script in 3.7 testing for the posix_spawn function.

@gpshead

gpshead commented May 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@ned-deily - what would you like to see for a Misc/NEWS.d entry for this. os.posix_spawn appeared in some betas but we're removing it before rc1. document it as being removed again? or just remove all prior mentions of adding it?

@gpshead gpshead self-assigned this May 14, 2018
@gpshead

gpshead commented May 14, 2018

Copy link
Copy Markdown
Member

err, wrong autocompleted. ned. sorry. :) @ned-deily :)

@gpshead gpshead requested a review from ned-deily May 14, 2018 16:23
gpshead added 2 commits May 14, 2018 11:35
@gpshead
Add a news entry. …
6a4a373 
and reference the removal from the old news entry where it was added.
@gpshead
Undo the autoconf related changes. …
5700952 
We can keep the configure test for posix_spawn, we'll need it in the
future and having it in pyconfig.h will be convenient in case any
3.7 extension module wants to use it.
@gpshead

gpshead commented May 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

okay, i've undone the configure changes and done the news entries. just waiting for the various CI runs to complete (overloaded by the sprints) before merging.

@gpshead gpshead removed the request for review from ned-deily May 14, 2018 18:48
@gpshead gpshead merged commit 8e633a4 into python:3.7 May 14, 2018
@pablogsal pablogsal deleted the remove_posix_spawn branch May 14, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @gpshead @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot