◐ Shell
reader mode source ↗
Skip to content

bpo-33509: Fix _warnings for module_globals=None#6833

Merged
vstinner merged 3 commits into
python:masterfrom
vstinner:warn_explicit_None
May 15, 2018
Merged

bpo-33509: Fix _warnings for module_globals=None#6833
vstinner merged 3 commits into
python:masterfrom
vstinner:warn_explicit_None

Conversation

@vstinner

@vstinner vstinner commented May 14, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Don't crash on warnings.warn_explicit() if module_globals is None.

https://bugs.python.org/issue33509

@vstinner
bpo-33509: Fix _warnings for module_globals=None …
c3741f9 
Don't crash on warnings.warn_explicit() if module_globals is None.
@vstinner vstinner requested review from 1st1 and serhiy-storchaka May 14, 2018 21:32
@serhiy-storchaka

serhiy-storchaka commented May 15, 2018

Copy link
Copy Markdown
Member

Sorry, I don't see you latest changes Victor.

@vstinner

vstinner commented May 15, 2018

Copy link
Copy Markdown
Member Author

Sorry, I don't see you latest changes Victor.

Woops. I just forgot to commit my changes... They are now published.

@vstinner vstinner merged commit b056562 into python:master May 15, 2018
@bedevere-bot

bedevere-bot commented May 15, 2018

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner vstinner deleted the warn_explicit_None branch May 15, 2018 18:42
@miss-islington

miss-islington commented May 15, 2018

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2018
@vstinner @miss-islington
bpo-33509: Fix _warnings for module_globals=None (pythonGH-6833) …
3d6fed8 
Don't crash on warnings.warn_explicit() if module_globals is not a dict.
(cherry picked from commit b056562)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot

bedevere-bot commented May 15, 2018

Copy link
Copy Markdown

GH-6870 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 15, 2018
@miss-islington @vstinner
bpo-33509: Fix _warnings for module_globals=None (GH-6833) …
820219f 
Don't crash on warnings.warn_explicit() if module_globals is not a dict.
(cherry picked from commit b056562)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @serhiy-storchaka @bedevere-bot @miss-islington @1st1 @the-knights-who-say-ni