◐ Shell
reader mode source ↗
Skip to content

bpo-33540: Add block_on_close attr to socketserver#6911

Merged
vstinner merged 5 commits into
python:masterfrom
vstinner:block_on_close
May 24, 2018
Merged

bpo-33540: Add block_on_close attr to socketserver#6911
vstinner merged 5 commits into
python:masterfrom
vstinner:block_on_close

Conversation

@vstinner

@vstinner vstinner commented May 16, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver.

https://bugs.python.org/issue33540

@vstinner vstinner requested review from pitrou and tiran May 16, 2018 16:26
vstinner added 2 commits May 22, 2018 22:54
@vstinner
bpo-33540: Add block_on_close attr to socketserver …
981f55b 
Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver.
@vstinner
Add NEWS entry
dc707f2
@vstinner

vstinner commented May 22, 2018

Copy link
Copy Markdown
Member Author

I rebased my PR.

ned-deily
ned-deily requested changes May 23, 2018
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

A few wording nits. Otherwise, LGTM

@bedevere-bot

bedevere-bot commented May 23, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

vstinner added 2 commits May 24, 2018 02:39
@vstinner
Merge branch 'master' into block_on_close
0b2551a
@vstinner
doc changes …
62216ef 
* old => pre-3.7
* remove an empty line
@vstinner

vstinner commented May 24, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 24, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@vstinner vstinner merged commit 453bd0b into python:master May 24, 2018
@vstinner vstinner deleted the block_on_close branch May 24, 2018 01:15
@miss-islington

miss-islington commented May 24, 2018

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 24, 2018

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 24, 2018

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 453bd0bc65b7ea6a18c43da69143ab10d54c0a35 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2018
@vstinner @miss-islington
bpo-33540: Add block_on_close attr to socketserver (pythonGH-6911) …
6e7efde 
Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour.
(cherry picked from commit 453bd0b)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot

bedevere-bot commented May 24, 2018

Copy link
Copy Markdown

GH-7088 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 24, 2018
@miss-islington @vstinner
bpo-33540: Add block_on_close attr to socketserver (GH-6911) …
fa286ed 
Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour.
(cherry picked from commit 453bd0b)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@tiran tiran Awaiting requested review from tiran

@pitrou pitrou Awaiting requested review from pitrou

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @bedevere-bot @miss-islington @ned-deily @the-knights-who-say-ni