bpo-13631: Fix the order of initialization for readline/editline.#6915
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
I added my GitHub username to my b.p.o. profile. |
Sorry, something went wrong.
ned-deily
left a comment
There was a problem hiding this comment.
In general, it looks pretty good (other than the couple of nits) and it works! Thanks for making the PR and not giving up. It would be nice to have a test case for it added to Lib/test/test_readline.py so we don't break it again but it might be challenging to construct such a test so I wouldn't insist on it.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
One other issue, which I just noticed. The Python doc builder has a checker tool that checks for potential problems in the doc source files. The check is run with |
Sorry, something went wrong.
The editline emulation needs to be initialized *after* the name is defined. This fixes the long open issue.
6853fb6 to
75ad317
Compare
May 17, 2018 05:28
|
Ned, thanks a lot for reviewing. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
Sorry, something went wrong.
|
Thanks @zvezdan for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, something went wrong.
…cOS. (pythonGH-6915) The editline emulation needs to be initialized *after* the name is defined. This fixes the long open issue. (cherry picked from commit c2f082e) Co-authored-by: Zvezdan Petkovic <zpetkovic@acm.org>
|
Oh. I started to review the change and it has just been merged, nice :-) Thank you Zvezdan Petkovic (@zvezdan) and congrats for your first PR merged into CPython! ✨ 🍰 ✨ |
Sorry, something went wrong.
The editline emulation needs to be initialized after the name is
defined. This fixes the long open issue.
https://bugs.python.org/issue13631