◐ Shell
reader mode source ↗
Skip to content

bpo-33582: Emit deprecation warning for formatargspec#6994

Merged
ned-deily merged 3 commits into
python:masterfrom
Carreau:deprecated-formatargspec
Jun 11, 2018
Merged

bpo-33582: Emit deprecation warning for formatargspec#6994
ned-deily merged 3 commits into
python:masterfrom
Carreau:deprecated-formatargspec

Conversation

@Carreau

@Carreau Carreau commented May 19, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Also assert it emits deprecation warnings in corresponding test, and add that into the docstring.

https://bugs.python.org/issue33582

@Carreau Carreau force-pushed the deprecated-formatargspec branch from 0033e03 to bddb788 Compare May 21, 2018 21:22
taleinat
taleinat requested changes Jun 10, 2018
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Just two minor fixes before this can go in, IMO.

@bedevere-bot

bedevere-bot commented Jun 10, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Carreau Carreau force-pushed the deprecated-formatargspec branch from f1bfa0b to 7ff49d6 Compare June 11, 2018 12:35
@Carreau Carreau force-pushed the deprecated-formatargspec branch from 7ff49d6 to b0e3d14 Compare June 11, 2018 12:35
@Carreau

Carreau commented Jun 11, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 11, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@methane, @taleinat: please review the changes made to this pull request.

@ned-deily

ned-deily commented Jun 11, 2018

Copy link
Copy Markdown
Member

OK, let's get this in for 3.7.0.

@ned-deily ned-deily merged commit 46c5cd0 into python:master Jun 11, 2018
@miss-islington

miss-islington commented Jun 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @Carreau for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 11, 2018

Copy link
Copy Markdown

GH-7645 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2018
@Carreau @miss-islington
bpo-33582: Emit deprecation warning for formatargspec (pythonGH-6994) …
20c7051 
(cherry picked from commit 46c5cd0)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
miss-islington added a commit that referenced this pull request Jun 11, 2018
@miss-islington @Carreau
bpo-33582: Emit deprecation warning for formatargspec (GH-6994) …
60b8274 
(cherry picked from commit 46c5cd0)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
@Carreau

Carreau commented Jun 12, 2018

Copy link
Copy Markdown
Contributor Author

Thanks !

@Carreau Carreau deleted the deprecated-formatargspec branch October 20, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@taleinat taleinat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Carreau @bedevere-bot @ned-deily @miss-islington @methane @taleinat @the-knights-who-say-ni