◐ Shell
reader mode source ↗
Skip to content

bpo-33602: Remove set and queue references from Data Types#7055

Merged
JulienPalard merged 3 commits into
python:masterfrom
andresdelfino:data-types
Sep 10, 2019
Merged

bpo-33602: Remove set and queue references from Data Types#7055
JulienPalard merged 3 commits into
python:masterfrom
andresdelfino:data-types

Conversation

@andresdelfino

@andresdelfino andresdelfino commented May 22, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino changed the title bpo33602 - Remove set and queue references from Data Types May 22, 2018
rhettinger
rhettinger previously requested changes May 22, 2018
View reviewed changes

@rhettinger rhettinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please leave "heap queues" and "synchronized queues" as-is. They lose some of their meaning if you factor out the word "queue" which means something slightly different in each of the three cases.

Go ahead with removing "set" and adding "enumerations"

@bedevere-bot

bedevere-bot commented May 22, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino

andresdelfino commented May 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rhettinger I removed "synchronized queues" because they are now described in Concurrent Execution, and it seemed confusing to mention them if they are not listed below.

I see your point about "heap" without "queue" attached to it, though. I can omit the mention to double-ended queues, so it reads "heap queues" again. Or perhaps "heap queues, double-ended queues, ...", but this sounded repetitive to me.

Would that be ok for you?

@andresdelfino

andresdelfino commented May 22, 2018

Copy link
Copy Markdown
Contributor Author

While I didn't literally made the requested changes, I'm pretty sure I addressed the issue raised and I think there was a confusion between "synchronized queues" and "double-ended queues", so:

I have made the requested changes; please review again

If I was wrong, I'll be glad to amend any error.

@bedevere-bot bedevere-bot removed the label May 22, 2018
@bedevere-bot

bedevere-bot commented May 22, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger, @serhiy-storchaka: please review the changes made to this pull request.

@andresdelfino

andresdelfino commented Jun 15, 2018

Copy link
Copy Markdown
Contributor Author

@rhettinger any chance you could give a look at the changes made and my comments?

@andresdelfino

andresdelfino commented Jul 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rhettinger could you take a look at the changes I made after your comments? Please note the comment I left in #7055 (review)

@andresdelfino

andresdelfino commented Oct 19, 2018

Copy link
Copy Markdown
Contributor Author

@rhettinger Do you approve of the changes made on the commits following your request?

@vstinner

vstinner commented Jan 10, 2019

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@andresdelfino

andresdelfino commented Feb 23, 2019

Copy link
Copy Markdown
Contributor Author

@rhettinger could you take a look at this?

@andresdelfino

andresdelfino commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka could you -as the other reviewer of this PR- take a look on the changes made and see if they address the concerns Raymond shared?

@JulienPalard JulienPalard dismissed rhettinger’s stale review September 10, 2019 14:36

Has been resolved by the author.

@JulienPalard JulienPalard reopened this Sep 10, 2019
@JulienPalard

JulienPalard commented Sep 10, 2019

Copy link
Copy Markdown
Member

(closing and re-opening to restart CI, Azure was stuck)

@JulienPalard JulienPalard merged commit 9121088 into python:master Sep 10, 2019
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@andresdelfino @miss-islington
bpo-33602: Doc: Remove set and queue references from Data Types (pyth… …
3009d17 
…onGH-7055)

(cherry picked from commit 9121088)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15875 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@andresdelfino @miss-islington
bpo-33602: Doc: Remove set and queue references from Data Types (pyth… …
5b25732 
…onGH-7055)

(cherry picked from commit 9121088)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15876 is a backport of this pull request to the 3.7 branch.

@andresdelfino andresdelfino deleted the data-types branch September 10, 2019 15:30
JulienPalard pushed a commit that referenced this pull request Sep 10, 2019
@miss-islington @andresdelfino @JulienPalard
bpo-33602: Doc: Remove set and queue references from Data Types (GH-7055 …
58ef7d3 
) (GH-15875)

(cherry picked from commit 9121088)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
JulienPalard pushed a commit that referenced this pull request Sep 10, 2019
@miss-islington @andresdelfino @JulienPalard
bpo-33602: Doc: Remove set and queue references from Data Types (GH-7055 …
816825e 
) (GH-15876)

(cherry picked from commit 9121088)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@JulienPalard

JulienPalard commented Sep 10, 2019

Copy link
Copy Markdown
Member

@andresdelfino thanks!

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@andresdelfino @websurfer5
bpo-33602: Doc: Remove set and queue references from Data Types (pyth… …
b7a1b1f 
…onGH-7055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@rhettinger rhettinger rhettinger left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@andresdelfino @bedevere-bot @vstinner @JulienPalard @miss-islington @rhettinger @serhiy-storchaka @the-knights-who-say-ni