◐ Shell
reader mode source ↗
Skip to content

bpo-33672: Fix Task.__repr__ crash with Cython's bogus coroutines#7161

Merged
1st1 merged 2 commits into
python:masterfrom
1st1:fixcy
May 28, 2018
Merged

bpo-33672: Fix Task.__repr__ crash with Cython's bogus coroutines#7161
1st1 merged 2 commits into
python:masterfrom
1st1:fixcy

Conversation

@1st1

@1st1 1st1 commented May 28, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@1st1 1st1 requested a review from asvetlov as a code owner May 28, 2018 16:30
asvetlov
asvetlov reviewed May 28, 2018
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I have some minor questions and ideas for improvement.
Would be nice to address them before merging.

asvetlov
asvetlov approved these changes May 28, 2018
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.
I share the opinion that the code could be improved/rewritten but for sake of minimal Python 3.7 impact let's keep changes small.

@1st1 1st1 merged commit 989b9e0 into python:master May 28, 2018
@1st1 1st1 deleted the fixcy branch May 28, 2018 20:27
@miss-islington

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor

Sorry, @1st1, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 989b9e0e6d7dd2fa911f9bfd4744e7f3a82d6006 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@miss-islington
bpo-33672: Fix Task.__repr__ crash with Cython's bogus coroutines (py… …
5a2a44d 
…thonGH-7161)

(cherry picked from commit 989b9e0)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot

bedevere-bot commented May 28, 2018

Copy link
Copy Markdown

GH-7173 is a backport of this pull request to the 3.7 branch.

1st1 pushed a commit that referenced this pull request May 28, 2018
@miss-islington
bpo-33672: Fix Task.__repr__ crash with Cython's bogus coroutines (GH… …
075c662 
…-7161) (GH-7173)

(cherry picked from commit 989b9e0)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scoder scoder scoder left review comments

@asvetlov asvetlov asvetlov approved these changes

Assignees

@1st1 1st1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@1st1 @miss-islington @bedevere-bot @asvetlov @scoder @the-knights-who-say-ni