◐ Shell
reader mode source ↗
Skip to content

bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name#7195

Merged
JulienPalard merged 3 commits into
python:masterfrom
geryogam:patch-1
May 29, 2018
Merged

bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name#7195
JulienPalard merged 3 commits into
python:masterfrom
geryogam:patch-1

Conversation

@geryogam

@geryogam geryogam commented May 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes the class name http.server.ThreadedHTTPServer to http.server.ThreadingHTTPServer introduced by @JulienPalard on 23 March 2018 for Python 3.7, in order to be consistent with the already existing classes:

  • socketserver.ForkingTCPServer;
  • socketserver.ForkingUDPServer;
  • socketserver.ThreadingTCPServer;
  • socketserver.ThreadingUDPServer.

https://bugs.python.org/issue31639

@JulienPalard

JulienPalard commented May 29, 2018

Copy link
Copy Markdown
Member

LGTM, it make sense, but can probably only be merged before 3.7.0, as changing it after would mean breaking compatibility.

vstinner
vstinner approved these changes May 29, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM if and only if the change is merged into 3.7 before 3.7 final.

The change doesn't break the backward compatibility because the renamed class has been introduced in Python 3.7 which is not released yet (beta versions have been released, but not the 3.7.0 final).

@JulienPalard JulienPalard merged commit 1cee216 into python:master May 29, 2018
@miss-islington

miss-islington commented May 29, 2018

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 29, 2018

Copy link
Copy Markdown
Contributor

Sorry, @maggyero and @JulienPalard, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1cee216cf383eade641aed22f4ec7d4cb565ecff 3.7

@elprans

elprans commented May 29, 2018

Copy link
Copy Markdown
Contributor

You forgot to update the entry in What's New.

JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request May 29, 2018
@geryogam @JulienPalard
[3.7] bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer cla… …
1f1ed23 
…ss name (pythonGH-7195).

(cherry picked from commit 1cee216)
@bedevere-bot

bedevere-bot commented May 29, 2018

Copy link
Copy Markdown

GH-7219 is a backport of this pull request to the 3.7 branch.

@JulienPalard

JulienPalard commented May 29, 2018

Copy link
Copy Markdown
Member

@elprans Hey thanks for noticing, I'm fixing it and will backport both in the same PR in 3.7.

@JulienPalard JulienPalard mentioned this pull request May 29, 2018
Merged
JulienPalard added a commit that referenced this pull request May 30, 2018
@JulienPalard
[3.7] bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer cla… …
4f53e2a 
…ss name (GH-7195) (GH-7219)

* [3.7] bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name (GH-7195).
(cherry picked from commit 1cee216)

* Fix whatsnew entry about ThreadedHTTPServer. (GH-7220)
(cherry picked from commit a34e424)
@geryogam geryogam deleted the patch-1 branch May 30, 2018 21:37
@geryogam

geryogam commented May 30, 2018

Copy link
Copy Markdown
Contributor Author

@JulienPalard Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

@JulienPalard JulienPalard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@geryogam @JulienPalard @miss-islington @elprans @bedevere-bot @vstinner @the-knights-who-say-ni