◐ Shell
reader mode source ↗
Skip to content

[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208)#7215

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-5d97b7b-3.7
May 29, 2018
Merged

[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208)#7215
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-5d97b7b-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented May 29, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Original patch by Dan O'Reilly.
(cherry picked from commit 5d97b7b)

Co-authored-by: Yury Selivanov yury@magic.io

https://bugs.python.org/issue22087

@miss-islington
bpo-22087: Fix Policy.get_event_loop() to detect fork (pythonGH-7208) …
3969a51 
Original patch by Dan O'Reilly.
(cherry picked from commit 5d97b7b)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2018
Merged
vstinner
vstinner requested changes May 29, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

IHMO it's too late for 3.7.

@bedevere-bot

bedevere-bot commented May 29, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner

vstinner commented May 29, 2018

Copy link
Copy Markdown
Member

https://bugs.python.org/issue22087 is as old as asyncio and people learnt how to work around the issue. I don't think that there is any kind of urgency to merge this change into 3.7. I would prefer to leave 3.7 unchanged, and test the change in 3.8 instead. It's too late for 3.7, we are very close to the 3.7rc1.

@1st1

1st1 commented May 29, 2018

Copy link
Copy Markdown
Member

I don't see why it's too late.

is as old as asyncio and people learnt how to work around the issue

This doesn't sound as an actual explanation why this shouldn't be merged. I don't see any technical problem with this patch or how it can possibly break anything.

@miss-islington

miss-islington commented May 29, 2018

Copy link
Copy Markdown
Contributor Author

@1st1: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2a7eb0b into python:3.7 May 29, 2018
@miss-islington

miss-islington commented May 29, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-5d97b7b-3.7 branch May 29, 2018 21:09
@danoreilly danoreilly mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @vstinner @1st1 @the-knights-who-say-ni