◐ Shell
reader mode source ↗
Skip to content

bpo-33509: Fix test_warnings for python3 -Werror#7365

Merged
ned-deily merged 1 commit into
python:masterfrom
vstinner:test_warnings
Jun 4, 2018
Merged

bpo-33509: Fix test_warnings for python3 -Werror#7365
ned-deily merged 1 commit into
python:masterfrom
vstinner:test_warnings

Conversation

@vstinner

@vstinner vstinner commented Jun 3, 2018

Copy link
Copy Markdown
Member

Fix test_warnings.test_module_globals() when python3 is run with
-Werror.

https://bugs.python.org/issue33509

Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
@vstinner

vstinner commented Jun 4, 2018

Copy link
Copy Markdown
Member Author

Close/Reopen to try to reschedule an AppVeyor job.

@vstinner vstinner closed this Jun 4, 2018
@vstinner vstinner reopened this Jun 4, 2018
@vstinner

vstinner commented Jun 4, 2018

Copy link
Copy Markdown
Member Author

Hum. Close/reopen was not enough to schedule a job on AppVeyor. It seems like AppVeyor doesn't want to spawn new jobs because we exceeded some quotas.

@ned-deily ned-deily merged commit e292b75 into python:master Jun 4, 2018
@bedevere-bot bedevere-bot removed the label Jun 4, 2018
@vstinner vstinner deleted the test_warnings branch June 4, 2018 06:41
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-7384 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2018
Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Jun 4, 2018
Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants