◐ Shell
reader mode source ↗
Skip to content

bpo-22708: Fix http protocol version in CONNECT method, support IDN#742

Closed
vo-va wants to merge 1 commit into
python:masterfrom
vo-va:fix-issue-22708
Closed

bpo-22708: Fix http protocol version in CONNECT method, support IDN#742
vo-va wants to merge 1 commit into
python:masterfrom
vo-va:fix-issue-22708

Conversation

@vo-va

@vo-va vo-va commented Mar 20, 2017

Copy link
Copy Markdown

Original author of this patch demianbrecht@gmail.com

HTTP/1.0 not supported CONNECT method, fix http version.
Support for IDN.

https://bugs.python.org/issue22708

@vo-va
Fix http protocol version in CONNECT method, support IDN …
a9b201c 
Original author of this patch demianbrecht@gmail.com
@brettcannon

brettcannon commented Mar 24, 2017

Copy link
Copy Markdown
Member

FYI for any other core dev, Demian Brecht has signed the CLA.

berkerpeksag
berkerpeksag requested changes Apr 15, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please also include the NEWS entry in the original patch and append "Patch by Demian Brecht.".

@berkerpeksag

berkerpeksag commented Apr 15, 2017

Copy link
Copy Markdown
Member

And please rebase your branch so we can run the tests on AppVeyor.

@brettcannon

brettcannon commented Feb 21, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@handlerbot handlerbot mentioned this pull request Jul 16, 2018
Merged
@berkerpeksag

berkerpeksag commented Jul 17, 2018

Copy link
Copy Markdown
Member

Superseded by PR #8305.

@vo-va vo-va mannequin mentioned this pull request Dec 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vo-va @brettcannon @berkerpeksag @Mariatta @the-knights-who-say-ni