◐ Shell
reader mode source ↗
Skip to content

bpo-33630: Fix memory leak in old versions of glicb for posix_spawn.#7685

Merged
serhiy-storchaka merged 9 commits into
python:masterfrom
pablogsal:bpo33630-2
Jun 19, 2018
Merged

bpo-33630: Fix memory leak in old versions of glicb for posix_spawn.#7685
serhiy-storchaka merged 9 commits into
python:masterfrom
pablogsal:bpo33630-2

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 13, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal changed the title bpo-33630: Fix memory leak in older versions of glicb for posix_spawn. Jun 13, 2018
@pablogsal pablogsal mentioned this pull request Jun 13, 2018
Closed
@pablogsal

pablogsal commented Jun 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is complementing #7663. @serhiy-storchaka I have addressed your feedback in 07e1245

@pablogsal

pablogsal commented Jun 15, 2018

Copy link
Copy Markdown
Member Author

I can confirm again that this fixes the buildbot problems. Tested on the buildbot itself:

[pablogsal@gcc1-power7 cpython]$ git rev-parse HEAD
6db5f32e0236deba37d7799801dd605c40ecd025


[pablogsal@gcc1-power7 cpython]$ uname -a
Linux gcc1-power7.osuosl.org 3.10.0-514.26.2.el7.ppc64 #1 SMP Mon Jul 10 02:26:53 GMT 2017 ppc64 ppc64 ppc64 GNU/Linux

[pablogsal@gcc1-power7 cpython]$ ./configure --with-pydebug && make -j
....

[pablogsal@gcc1-power7 cpython]$ ./python -m unittest test.test_posix
ss....s....................ss................ss............s...s.....................................
----------------------------------------------------------------------
Ran 101 tests in 1.916s

OK (skipped=9)
[pablogsal@gcc1-power7 cpython]$ ./python -m test test_posix -R 3:3
Run tests sequentially
0:00:00 load avg: 7.20 [1/1] test_posix
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 6 sec
Tests result: SUCCESS

@pablogsal

pablogsal commented Jun 15, 2018

Copy link
Copy Markdown
Member Author

It seems that the problem covered by #7663 (the race in the test) disappears once this is fixed. As is a race condition I am not sure, but running 3 test suites in parallel that executes test_posix 200 times does not raise any problem on the buildbot.

serhiy-storchaka
serhiy-storchaka reviewed Jun 15, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you @pablogsal for your responsibility!

LGTM in general, added just few stylistic comments.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news labels Jun 15, 2018
@pablogsal

pablogsal commented Jun 15, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@serhiy-storchaka I have rewritten a bit the comment in 0e3348e to make it more clear.

@serhiy-storchaka serhiy-storchaka merged commit cb97073 into python:master Jun 19, 2018
@pablogsal pablogsal deleted the bpo33630-2 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @serhiy-storchaka @zhangyangyu @the-knights-who-say-ni @bedevere-bot