◐ Shell
reader mode source ↗
Skip to content

bpo-33855: Minimally test all IDLE modules.#7689

Merged
terryjreedy merged 30 commits into
python:masterfrom
terryjreedy:moretests
Jun 15, 2018
Merged

bpo-33855: Minimally test all IDLE modules.#7689
terryjreedy merged 30 commits into
python:masterfrom
terryjreedy:moretests

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Jun 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member 
for implementation module in idlelib modules:
    if test_module not in idle_test:
        create test_module from template.py;   add 'module' to docstring
        import module and check other minimal imports
        create instance of each class, with requires('gui') if needed
        add initial coverage of this test
        add test invocation to module
    else:
        check same for existing test

https://bugs.python.org/issue33855

@terryjreedy terryjreedy changed the title bpo-33855: Minimally test all IDLE files. Jun 14, 2018
@terryjreedy terryjreedy added needs backport to 3.6 tests Tests in the Lib/test dir labels Jun 14, 2018
@terryjreedy terryjreedy self-assigned this Jun 14, 2018
willingc
willingc reviewed Jun 14, 2018
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @terryjreedy. I noticed one possible typo. LGTM.

30 hidden items Load more…
@terryjreedy terryjreedy deleted the moretests branch June 15, 2018 22:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2018
@terryjreedy @miss-islington
bpo-33855: Minimally test all IDLE modules. (pythonGH-7689) …
fe09f36 
Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es).  Add a test file for all non-startup IDLE modules.  Edit existing files and update coverage.  This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files.
(cherry picked from commit ee5ef30)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot

bedevere-bot commented Jun 15, 2018

Copy link
Copy Markdown

GH-7731 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Jun 15, 2018

Copy link
Copy Markdown
Contributor

Sorry, @terryjreedy, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5ef309c7e2daef1248730145408f700732c42e 3.6

miss-islington added a commit that referenced this pull request Jun 15, 2018
@miss-islington @terryjreedy
bpo-33855: Minimally test all IDLE modules. (GH-7689) …
5085687 
Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es).  Add a test file for all non-startup IDLE modules.  Edit existing files and update coverage.  This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files.
(cherry picked from commit ee5ef30)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jun 15, 2018
@terryjreedy
[3.6] bpo-33855: Minimally test all IDLE modules. (pythonGH-7689) …
4675e81 
Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es).  Add a test file for all non-startup IDLE modules.  Edit existing files and update coverage.  This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files..
(cherry picked from commit ee5ef30)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot

bedevere-bot commented Jun 15, 2018

Copy link
Copy Markdown

GH-7734 is a backport of this pull request to the 3.6 branch.

terryjreedy added a commit that referenced this pull request Jun 16, 2018
@terryjreedy
[3.6] bpo-33855: Minimally test all IDLE modules. (GH-7689) (GH-7734) …
833b3d2 
Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es).  Add a test file for all non-startup IDLE modules.  Edit existing files and update coverage.  This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files..
(cherry picked from commit ee5ef30)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy mentioned this pull request Jun 17, 2018
Merged
@miss-islington miss-islington mentioned this pull request Jun 18, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@terryjreedy @miss-islington
bpo-33855: More edits and new minimal tests for IDLE (pythonGH-7761) …
d34d461 
Part 2 of 3.  Continues PR pythonGH-7689, changeset ee5ef30.
Edit and add tests for 18 modules, help_about to replace and run.
(cherry picked from commit ea3dc80)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@terryjreedy @miss-islington
bpo-33855: More edits and new minimal tests for IDLE (pythonGH-7761) …
4b14bce 
Part 2 of 3.  Continues PR pythonGH-7689, changeset ee5ef30.
Edit and add tests for 18 modules, help_about to replace and run.
(cherry picked from commit ea3dc80)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@miss-islington miss-islington mentioned this pull request Jun 18, 2018
Merged
terryjreedy added a commit that referenced this pull request Jun 18, 2018
@terryjreedy
bpo-33855: More edits and new minimal tests for IDLE (GH-7761) …
ea3dc80 
Part 2 of 3.  Continues PR #7689, changeset ee5ef30.
Edit and add tests for 18 modules, help_about to replace and run.
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @terryjreedy
bpo-33855: More edits and new minimal tests for IDLE (GH-7761) …
740f1cb 
Part 2 of 3.  Continues PR GH-7689, changeset ee5ef30.
Edit and add tests for 18 modules, help_about to replace and run.
(cherry picked from commit ea3dc80)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @terryjreedy
bpo-33855: More edits and new minimal tests for IDLE (GH-7761) …
684bc3d 
Part 2 of 3.  Continues PR GH-7689, changeset ee5ef30.
Edit and add tests for 18 modules, help_about to replace and run.
(cherry picked from commit ea3dc80)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy terryjreedy mentioned this pull request Jun 19, 2018
Merged
@miss-islington miss-islington mentioned this pull request Jun 19, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@terryjreedy @miss-islington
bpo-33855: Still more edits and minimal tests for IDLE (pythonGH-7784) …
8e7fd11 
Part 3 of 3, continuing PR pythonGH-7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
(cherry picked from commit 4d92158)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@miss-islington miss-islington mentioned this pull request Jun 19, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@terryjreedy @miss-islington
bpo-33855: Still more edits and minimal tests for IDLE (pythonGH-7784) …
736cb6f 
Part 3 of 3, continuing PR pythonGH-7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
(cherry picked from commit 4d92158)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Jun 19, 2018
@terryjreedy
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) …
4d92158 
Part 3 of 3, continuing PR #7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @terryjreedy
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) …
cbaee6f 
Part 3 of 3, continuing PR GH-7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
(cherry picked from commit 4d92158)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @terryjreedy
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) …
90209a1 
Part 3 of 3, continuing PR GH-7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
(cherry picked from commit 4d92158)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jun 20, 2018
@terryjreedy
bpo-33855: Minimally test all IDLE modules. (pythonGH-7689) …
c63dbcb 
Create a template for minimally testing a tkinter-using module by
importing it and instantiating its class(es).  Add a test file for
all non-startup IDLE modules.  Edit existing files and update coverage.
This is part 1 of 3, covering the 21 autocomplete to help modules and
touching 33 idlelib files.

(cherry picked from commit ee5ef30)

# Conflicts fixed:
#	Lib/idlelib/idle_test/test_calltip.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc left review comments

@zware zware zware left review comments

Assignees

@terryjreedy terryjreedy

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@terryjreedy @miss-islington @bedevere-bot @willingc @zware @the-knights-who-say-ni