◐ Shell
reader mode source ↗
Skip to content

Indicate that abs() method accept argument that implement __abs__(), …#7783

Closed
Windsooon wants to merge 1087 commits into
python:masterfrom
Windsooon:clean_docs
Closed

Indicate that abs() method accept argument that implement __abs__(), …#7783
Windsooon wants to merge 1087 commits into
python:masterfrom
Windsooon:clean_docs

Conversation

@Windsooon

@Windsooon Windsooon commented Jun 19, 2018

Copy link
Copy Markdown
Contributor

…just like call() method in the docs

@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 19, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@Windsooon

Windsooon commented Jun 19, 2018

Copy link
Copy Markdown
Contributor Author

I signed the CLA, Thank you for reviewing.

@Mariatta Mariatta removed the label Jul 13, 2018
@eric-wieser

This comment has been minimized.

Sign in to view
@Windsooon

Windsooon commented Aug 2, 2018

Copy link
Copy Markdown
Contributor Author

@eric-wieser Thanks, I fixed it now.

jdemeyer
jdemeyer requested changes Feb 4, 2019
View reviewed changes

@jdemeyer jdemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I think the wording could be improved: what does "The argument may be an integer or a floating point number." really mean now? You should explain that this applies to integers, floating point numbers, complex numbers and anything defining __abs__.

@matrixise matrixise added docs Documentation in the Doc dir skip issue skip news labels May 15, 2019
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

csabella commented Feb 4, 2020

Copy link
Copy Markdown
Contributor

@Windsooon, please resolve the merge conflict and address the code review comments. Thank you!

@eric-wieser

This comment has been minimized.

Sign in to view
@Windsooon Windsooon changed the title Indicate that add() method accept argument that implement __abs__(), … Feb 4, 2020
@Windsooon

Windsooon commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

To make it easier, how about

"... integer or a floating point number or anything defining __abs__. If the argument is a complex number, its magnitude is returned."

@eric-wieser

This comment has been minimized.

Sign in to view
@Windsooon Windsooon changed the title Indicate that add() method accept argument that implement __add__(), … Feb 4, 2020
@Windsooon

Windsooon commented Feb 4, 2020

Copy link
Copy Markdown
Contributor Author

Sorry for the mistake. I just fixed it.

@JulienPalard

JulienPalard commented Feb 5, 2020

Copy link
Copy Markdown
Member

To make it easier, how about

"... integer or a floating point number or anything defining __abs__. If the argument is a complex number, its magnitude is returned."

Yes, by using

:meth:`__abs__`

instead of a raw abs.

I'm not a native english speaker but I think the first or is now redundent, what about:

The argument may be an integer, a floating point number, or anything defining :meth:`__abs__`.

I'd maybe prefer a bit object over anything, like:

The argument may be an integer, a floating point number, or an object implementing :meth:`__abs__`.

@Windsooon

Windsooon commented Feb 6, 2020

Copy link
Copy Markdown
Contributor Author

@JulienPalard Thank you. I updated the PR based on your suggestion.

@JulienPalard

JulienPalard commented Feb 6, 2020

Copy link
Copy Markdown
Member

@Windsooon could you resolve the conflict?
I would personally do it using git fetch upstream; git rebase upstream/master (my python/cpython remote being named upstream), as your PR is based on a commit from 2018.

250 hidden items Load more…
@Windsooon Windsooon closed this May 29, 2020
@Windsooon Windsooon mentioned this pull request May 29, 2020
Merged
@terryjreedy

terryjreedy commented May 29, 2020

Copy link
Copy Markdown
Member

rebase commonly messes up branches and PRs with the cpython workflow. Did you do git merge in master before updating the branch? git merge upstream/master usually works. There might be a merge conflict, but not likely with a narrow PR like this one. You could still try merge on your local branch if not deleted yet.

@Windsooon

Windsooon commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy Thank you. I just delete the old branch. However, I don't know why my PR will conflict with the current master branch. I will check it out later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard requested changes

@jdemeyer jdemeyer jdemeyer requested changes

@1st1 1st1 Awaiting requested review from 1st1

@abalkin abalkin Awaiting requested review from abalkin

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

@gpshead gpshead Awaiting requested review from gpshead

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@methane methane Awaiting requested review from methane

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@pablogsal pablogsal Awaiting requested review from pablogsal

@pganssle pganssle

@rhettinger rhettinger Awaiting requested review from rhettinger

@skrah skrah Awaiting requested review from skrah

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

@tiran tiran Awaiting requested review from tiran

@vsajip vsajip Awaiting requested review from vsajip

@warsaw warsaw

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.