[3.7] bpo-33929: multiprocessing: fix handle leak on race condition (GH-7921)#7960
Conversation
Sorry, something went wrong.
…GH-7921) Fix a race condition in Popen of multiprocessing.popen_spawn_win32. The child process now duplicates the read end of pipe instead of "stealing" it. Previously, the read end of pipe was "stolen" by the child process, but it leaked a handle if the child process had been terminated before it could steal the handle from the parent process. (cherry picked from commit 2cc9d21) Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, good bot 🤖!
Sorry, something went wrong.
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
@pitrou doens't want to backport the fix:
#7921 (comment)
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
@vstinner: Backport status check is done, and it's a success ✅ . |
Sorry, something went wrong.
|
Oh. I approved the PR, but then I blocked it by voting -1 and... the bot merged the PR anyway :-( I reported the bot bug: python/miss-islington#111 |
Sorry, something went wrong.
Fix a race condition in Popen of
multiprocessing.popen_spawn_win32. The child process now duplicates
the read end of pipe instead of "stealing" it.
Previously, the read end of pipe was "stolen" by the child process,
but it leaked a handle if the child process had been terminated
before it could steal the handle from the parent process.
(cherry picked from commit 2cc9d21)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue33929