◐ Shell
reader mode source ↗
Skip to content

bpo-34060: Report system load when running test suite for Windows#8287

Closed
ammaraskar wants to merge 2 commits into
python:masterfrom
ammaraskar:windows_load
Closed

bpo-34060: Report system load when running test suite for Windows#8287
ammaraskar wants to merge 2 commits into
python:masterfrom
ammaraskar:windows_load

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Jul 15, 2018

Copy link
Copy Markdown
Member

See the bpo ticket for more technical details on the implementation and otherwise.

https://bugs.python.org/issue34060

@jkloth

jkloth commented Jul 15, 2018

Copy link
Copy Markdown
Contributor

A quick note on the LOADAVG_FACTOR_1F and SAMPLING_INTERVAL; that given dampening factor is for a sample rate of 5 seconds. SAMPLING_INTERVAL should really be changed to 5 or re-run the equation with the different interval.

@ammaraskar

Copy link
Copy Markdown
Member Author

Thanks again Jeremy, I changed the interval to 5 to be more in line with the Linux scheduler.

@ammaraskar

Copy link
Copy Markdown
Member Author

Also, I don't think this actually needs a NEWS entry right? It relates to cpython build process and doesn't actually affect the language. Could you mark it with the skip news label if so?

@zooba

zooba commented Jul 16, 2018

Copy link
Copy Markdown
Member

What extra runtime dependencies does this add to python38.dll (use dumpbin /imports python38.dll and grab the DLL filenames)?

Also, winapi methods are public, if undocumented (since they are supposed to reflect the Windows API calls directly, so that documentation should suffice). If you really want an internal test suite helper it should go in its own extension module with a _ prefix.

(Haven't looked too closely at the implementation yet, but when I do, it will be with the view that it is a public API change. Unless you rework it into its own module first.)

@zooba

zooba commented Jul 16, 2018

Copy link
Copy Markdown
Member

(Edited above post). Let me take that back - was thinking of winreg module, not the _winapi module. But it still should be treated as a publicly usable API with all the robustness guarantees unless it's in its own module, since it will be used.

@ammaraskar

Copy link
Copy Markdown
Member Author

Aah yeah I think you have a good point, _winapi despite being undocumented is being consumed by end users https://github.com/search?p=1&q=import+_winapi&type=Code

I think making it its own module would be a bit overkilll so I'll clean up the API anticipating some public usage.

@ammaraskar

Copy link
Copy Markdown
Member Author

Closed in favor of #8357

Thank you @csabella 😄

@ammaraskar ammaraskar closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants