◐ Shell
reader mode source ↗
Skip to content

[2.7] bpo-25083: Python 2 can sometimes create incorrect .pyc files#8449

Merged
encukou merged 1 commit into
python:2.7from
tzickel:fixioerror
Sep 10, 2018
Merged

[2.7] bpo-25083: Python 2 can sometimes create incorrect .pyc files#8449
encukou merged 1 commit into
python:2.7from
tzickel:fixioerror

Conversation

@tzickel

@tzickel tzickel commented Jul 24, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Python 2 never checked for I/O error when reading .py files and
thus could mistake an I/O error for EOF and create incorrect .pyc
files. This adds an check for this and aborts on an error.

https://bugs.python.org/issue25083

@tzickel

tzickel commented Jul 24, 2018

Copy link
Copy Markdown
Contributor Author

backport-pr is failing, because this is a Python 2 only issue.

@methane methane changed the title bpo-25083: Python 2 can sometimes create incorrect .pyc files Jul 24, 2018
@encukou

encukou commented Jul 28, 2018

Copy link
Copy Markdown
Member

This looks good except for the use of E_EOF. That should be reserved for end-of-file, but in this case here we're not getting to the end of file.
I don't see a good E_ constant for read errors in the current list. Could you add a new one in Include/errcode.h and Python/pythonrun.c, so that this gets a proper error message?

@encukou

encukou commented Jul 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

And don't worry about the backport title check; that's for the person who'll merge this.

@encukou encukou mentioned this pull request Jul 28, 2018
Closed
@tzickel

tzickel commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

Done.

@tzickel

tzickel commented Jul 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Here is a script to check for the bug:
https://gist.github.com/tzickel/2ab09100ea21ca0e1e6709c337194bff
needs a recent strace (ubuntu 18.04 or debian sed is fine), and if run inside a docker, the docker needs to be run with --cap-add SYS_PTRACE for strace to work.

@bedevere-bot

bedevere-bot commented Jul 31, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tzickel
bpo-25083: Python can sometimes create incorrect .pyc files …
8375c77 
Python 2 never checked for I/O error when reading .py files and
thus could mistake an I/O error for EOF and create incorrect .pyc
files. This adds an check for this and aborts on an error.
@tzickel

tzickel commented Aug 1, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Aug 1, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Aug 1, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, but I would prefer that someone else merge it.

@tzickel

tzickel commented Sep 3, 2018

Copy link
Copy Markdown
Contributor Author

@encukou I'm waiting for the convincing part :) I think it's best to merge this ASAP (if it's plan to be used), so it has maximum exposure before a new release.

@encukou encukou closed this Sep 10, 2018
@encukou encukou reopened this Sep 10, 2018
@encukou encukou merged commit f64c813 into python:2.7 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tzickel @encukou @bedevere-bot @vstinner