bpo-24241: Preferred X browser#85

davesteele

When calling webbrowser.open*(), the module goes through a list of installed browsers, and uses the first one that succeeds, to process the request.

The first 'browsers' in the 'X' list are 'xdg-open' and others of that ilk. The problem is that they only have one 'open' behavior - the 'new' parameter is ignored ('same window', 'new window', 'new tab').

These commits move the default web browser to the front of the tryorder list, allowing get() behavior to match the documentation.

This same problem was recently fixed in Windows via Issue #8232

the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

davesteele

I've tied my bpo 'daves' account to github 'davesteele'. The contributor form was received 2015-07-17.00:00:00.

codecov

Codecov Report

Merging #85 into master will decrease coverage by -0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   82.38%   82.38%   -0.01%     
==========================================
  Files        1428     1428              
  Lines      351138   351143       +5     
==========================================
- Hits       289291   289275      -16     
- Misses      61847    61868      +21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b692dc8...602ba9f. Read the comment docs.

ultimatecoder

Found improvements to the code.

ultimatecoder

I will suggest updating the documentation for method register at Doc/library/webbrowser.rst

davesteele

I've added documentation for the register() priority argument.

ncoghlan

I like the general idea of this patch, but think it would be more self-explanatory with some changes to the specific implementation details.

codecov-io

Codecov Report

Merging #85 into master will decrease coverage by -0.01%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   82.38%   82.37%   -0.01%     
==========================================
  Files        1428     1428              
  Lines      351138   351206      +68     
==========================================
+ Hits       289291   289317      +26     
- Misses      61847    61889      +42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b692dc8...795ee09. Read the comment docs.

davesteele

@ncoghlan, I've made some changes based on your review, and pushed back on a few others. You be the final arbiter on the issues. Let me know.

ncoghlan

+1 on leaving the helper variable as a single string - I've suggested a name change and an additional explanatory comment to cover some of the subtleties for future maintainers.

For the preferred change, I still think keyword-only arguments will be clearer, as preferred=True conveys a lot more information at the call sites than a bare True.

The commit message also still needs adjustment to better cover the changes being made (i.e. both the preferred parameter being added to webbrowser.register, and the module being updated to use xdg-settings to find the appropriate preferred browser on Linux).

If you're so inclined, you could also add an entry to the 3.7 What's New for this change (otherwise I'll just add it along with the NEWS entry when pushing the change)

Replace the existing undocumented tri-state 'try_order' parameter with the boolean keyword-only 'preferred' parameter. Setting it to True places the browser at the front of the list, preferring it as the return to a subsequent get() call. 'preferred' is added to the documentation.

The traditional first entry in the tryorder queue is xdg-open, which doesn't support new window. Make the default browser first in the try list, to properly support these options.

davesteele

@ncoghlan, I've reworked, reworded, and rebased the commits based on your suggestions.

ncoghlan

The codecov complaints are due to CI not running on Mac OS X, so this looks good to me now - merging!

davesteele

Thanks for your help on this.

ncoghlan

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

…WatchdogEx Fix issue python#85: don't schedule already scheduled tasklets. Ensure that the internal watchdog list is empty before and after all test cases of class TestNewWatchdog. Fix test case TestNewWatchdog.test_watchdog_priority_{hard|soft}. The timeout value was much to short to build up a list of watchdogs. The new test cases TestNewWatchdog.test_schedule_deeper_{hard|soft} triggers the assertion failure reliably. They are skipped for now. https://bitbucket.org/stackless-dev/stackless/issues/85 (grafted from 2235702eb90cb0709dd40544b3952a956f2032a9 and 3fb55ce5b2d4)

Sometimes we need to acquire locks before the current PyThreadState is set. This moves the waiter data to it's own struct. It's shared between PyThreadStates on the same thread, such as in multi-interpreter settings. Fixes #85

Add github workflow to build and publish docker image

the-knights-who-say-ni added the CLA not signed label Feb 14, 2017

davesteele changed the title ~~Issue #24241: Preferred X browser~~ Feb 14, 2017

zware removed the CLA not signed label Feb 14, 2017

the-knights-who-say-ni added the CLA signed label Feb 14, 2017

ultimatecoder reviewed Feb 18, 2017

View reviewed changes

ultimatecoder suggested changes Feb 18, 2017

View reviewed changes

merwok reviewed Feb 18, 2017

View reviewed changes

ncoghlan requested changes Feb 19, 2017

View reviewed changes

davesteele added 2 commits February 24, 2017 16:27

bpo-24241: xdg-settings for preferred X browser …

871455f

The traditional first entry in the tryorder queue is xdg-open, which doesn't support new window. Make the default browser first in the try list, to properly support these options.

davesteele force-pushed the preferred_browser branch from 795ee09 to 871455f Compare February 24, 2017 21:37

ncoghlan approved these changes Feb 25, 2017

View reviewed changes

ncoghlan merged commit e3ce695 into python:master Feb 25, 2017

ncoghlan mentioned this pull request Feb 25, 2017

Require code coverage not drop in a PR python/core-workflow#38

Closed

ncoghlan added the sprint label May 28, 2017

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

Enable a skiped test case for issue python#85

f76353a

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#81, python#85)

4717ee3

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Update aiohttp from 3.1.1 to 3.2.0 (#85)

443d0dd

markshannon pushed a commit to faster-cpython/cpython that referenced this pull request Jan 10, 2023

Merge pull request python#85 from lesteve/docker-build-push …

1761801

Add github workflow to build and publish docker image

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

ngoldbaum mentioned this pull request Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

sergey-miryanov mentioned this pull request Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

ngoldbaum mentioned this pull request Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Open

Conversation

davesteele commented Feb 14, 2017

Uh oh!

the-knights-who-say-ni commented Feb 14, 2017

Uh oh!

davesteele commented Feb 14, 2017

Uh oh!

codecov Bot commented Feb 14, 2017

Codecov Report

Uh oh!

ultimatecoder left a comment

Choose a reason for hiding this comment

Uh oh!

ultimatecoder left a comment

Choose a reason for hiding this comment

Uh oh!

davesteele commented Feb 18, 2017

Uh oh!

ncoghlan left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Feb 19, 2017

Codecov Report

Uh oh!

davesteele commented Feb 19, 2017

Uh oh!

ncoghlan commented Feb 23, 2017

Uh oh!

davesteele commented Feb 24, 2017

Uh oh!

ncoghlan commented Feb 25, 2017

Uh oh!

davesteele commented Feb 25, 2017

Uh oh!

ncoghlan commented May 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants