{{ message }}
bpo-34247: actually use environment variables in Py_Initialize#8521
Closed
ronaldoussoren wants to merge 1 commit into
Closed
bpo-34247: actually use environment variables in Py_Initialize#8521ronaldoussoren wants to merge 1 commit into
ronaldoussoren wants to merge 1 commit into
Conversation
Contributor
Sorry, something went wrong.
…sys.flags This patch moves a number of startup options from the _Py_CommandLineDetails to _PyCoreConfig to make it possible to process them in Py_Initialize, actually uses this and adds a function to update the relevant global variables from _Py_Initialize.
ronaldoussoren
commented
Jul 28, 2018
ronaldoussoren
commented
Jul 28, 2018
Member
|
I merged my PR #8659 instead which is more complete and contains unit tests. Thanks for your PR anyway! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
As mentioned in bpo-34247 a program embedding Python with Py_Initialize / Py_Run... (no Py_Main) cannot affect a number of interpreter options through environment variables.
This is a pull request against the 3.7 branch, primarily because Nick Coghlan mentioned that there is related work on the master branch by Victor Stinner (bpo-34170).
The patch works for me, but I haven't dug deeply enough in the code to be sure that this is the right patch, I'm particularly unsure about the additional argument to _PyCoreConfig_Read.
https://bugs.python.org/issue34247