◐ Shell reader mode source ↗

gh-68443: Replace debug level-related logic in http client with logging#8633

Open

CuriousLearner wants to merge 2 commits into

python:mainfrom

CuriousLearner:fix-issue24255

CuriousLearner commented Aug 2, 2018 •

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Hey @bitdancer , here's the PR for issue: https://bugs.python.org/issue24255

https://bugs.python.org/issue24255

Issue: Replace debuglevel-related logic with logging #68443

the-knights-who-say-ni added the CLA signed label Aug 2, 2018

bedevere-bot added the awaiting review label Aug 2, 2018

CuriousLearner commented Aug 7, 2018 •

edited

Loading

Copy link Copy Markdown

Member Author

@vsajip Hello, I see that there are various linting errors in test_logging.py which were fixed in 5f63c20. Does it make sense to separate them out in another Pull Request?

willingc self-requested a review October 7, 2018 09:23

CuriousLearner commented May 9, 2019

Copy link Copy Markdown

Member Author

Hey @bitdancer , @vsajip

Can you please have a look at this? I just noticed this PR wasn't reviewed from almost a year. Please let me know, what is needed here.

Thanks!

willingc commented May 9, 2019

Copy link Copy Markdown

Contributor

@CuriousLearner I would go ahead and rebase to resolve conflicts.

CuriousLearner commented May 11, 2019

Copy link Copy Markdown

Member Author

@willingc Done!

dhilst reviewed Jun 21, 2019

View reviewed changes

dhilst reviewed Jun 21, 2019

View reviewed changes

vsajip reviewed Jun 21, 2019

View reviewed changes

csabella requested a review from bitdancer February 25, 2020 12:34

demianbrecht mannequin mentioned this pull request Apr 10, 2022

Replace debuglevel-related logic with logging #68443

Open

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions Bot commented Dec 15, 2024

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 15, 2024

picnixz changed the title ~~bpo-24255: Replace debug level-related logic in http client with logging~~ Dec 15, 2024

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 27, 2025

github-actions Bot commented Apr 13, 2025

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2025

python-cla-bot Bot commented Apr 18, 2025 •

edited

Loading

Copy link Copy Markdown

All commit authors signed the Contributor License Agreement.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 18, 2025

github-actions Bot commented Jun 15, 2025

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Oct 12, 2025

github-actions Bot commented Nov 11, 2025

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 11, 2025

CuriousLearner force-pushed the fix-issue24255 branch from 9933ad5 to b6997e1 Compare November 14, 2025 00:49

CuriousLearner requested review from asvetlov, dhilst and vsajip November 14, 2025 01:02

CuriousLearner removed the stale Stale PR or inactive for long period of time. label Nov 14, 2025


          bpo-24255: Replace debug prints with logging in http.client

…

afeb73c

Replace debuglevel-based print statements with Python's standard
logging module for better integration with logging frameworks and
log aggregation tools like Sentry. Uses % formatting consistently
for better log pattern matching in aggregation tools.

CuriousLearner force-pushed the fix-issue24255 branch from c240289 to afeb73c Compare December 7, 2025 02:13

github-actions Bot commented Jan 6, 2026

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 6, 2026


          Merge branch 'main' into fix-issue24255

c4bacf1

tpikonen reviewed May 6, 2026

View reviewed changes

tpikonen left a comment

Copy link Copy Markdown

I ran into the problem (logging with print, which gives no timestamps etc.) this PR is fixing, and I hope it gets merged.

But, this patch has several style-related changes, which should be put into a separate commit. It also looks to me that there is some print usage left and some debug output which this patch removes, see my comments.

github-actions Bot removed the stale label May 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

willingc Awaiting requested review from willingc

bitdancer Awaiting requested review from bitdancer

vsajip Awaiting requested review from vsajip vsajip is a code owner

asvetlov Awaiting requested review from asvetlov

dhilst Awaiting requested review from dhilst

1 more reviewer

tpikonen tpikonen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

Milestone

No milestone