{{ message }}
bpo-34373: fix test_mktime and test_pthread_getcpuclickid tests on AIX#8726
Merged
ncoghlan merged 7 commits intoDec 28, 2018
Merged
bpo-34373: fix test_mktime and test_pthread_getcpuclickid tests on AIX#8726ncoghlan merged 7 commits into
ncoghlan merged 7 commits into
Conversation
Contributor
Sorry, something went wrong.
add range checking for _PyTime_localtime (for AIX)
pablogsal
reviewed
Aug 12, 2018
pablogsal
reviewed
Aug 12, 2018
pablogsal
reviewed
Aug 14, 2018
ncoghlan
approved these changes
Dec 26, 2018
ncoghlan
left a comment
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
This mostly looks good to me, just one question regarding whether or not the ctypes dependency in the test case can be avoided (hence the approving review, rather than an immediate merge).
Sorry, something went wrong.
ncoghlan
approved these changes
Dec 28, 2018
Member
|
tt is now modified before it is checked if it's equal to (time_t)-1. It looks like a regression to me: I wrote PR #12726 to propose a fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
fix test_mktime and test_pthread_getcpuclickid tests
add range checking for _PyTime_localtime (for AIX)
https://bugs.python.org/issue34373