◐ Shell
reader mode source ↗
Skip to content

Remove redundant if check from argparser file.#8766

Merged
benjaminp merged 1 commit into
python:masterfrom
sp1rs:master
Jun 21, 2019
Merged

Remove redundant if check from argparser file.#8766
benjaminp merged 1 commit into
python:masterfrom
sp1rs:master

Conversation

@sp1rs

@sp1rs sp1rs commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

Remove redundant if check from optional argument function in argparser.

@sp1rs
Update argparse.py …
43276dd 
 Remove redundant if check from optional argument function in argparser.
@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 14, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@sp1rs

sp1rs commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

signed the CLA, Please remove the CLA not signed label.

@andresdelfino andresdelfino mentioned this pull request Aug 14, 2018
Merged
asottile
asottile approved these changes Aug 17, 2018
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

yeah you;re right, seems fine -- didn't notice the statement in the middle so elif would be way more work than necessary.

@sp1rs

sp1rs commented Aug 24, 2018

Copy link
Copy Markdown
Contributor Author

@asottile How and when will this Pull request be approved and merged to master?

@asottile

asottile commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

No idea, I'm just a rando

@sp1rs

sp1rs commented Nov 29, 2018

Copy link
Copy Markdown
Contributor Author

@bedevere-bot Please someone review.

@csabella csabella requested review from benjaminp and merwok May 19, 2019 00:45
@sp1rs

sp1rs commented Jun 20, 2019

Copy link
Copy Markdown
Contributor Author

@benjaminp @merwok Please review the PR.

@merwok merwok removed their request for review June 20, 2019 16:03
@benjaminp benjaminp merged commit b9600b0 into python:master Jun 21, 2019
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jun 21, 2019
@CuriousLearner
Merge branch 'master' into fix-issue24255 …
7bf6445 
* master: (599 commits)
  Docs: Improved phrasing (pythonGH-14069)
  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)
  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)
  Update What's New in Python 3.9 (pythonGH-14253)
  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)
  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)
  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)
  Fix bpo number in News file. (pythonGH-14260)
  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)
  Update What's New in Python 3.8 (pythonGH-14239)
  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)
  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)
  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)
  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)
  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)
  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)
  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)
  Fix name of '\0'. (pythonGH-14222)
  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)
  Document typing.ForwardRef (pythonGH-14216)
  ...
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@sp1rs @lisroach
Remove redundant if check from optional argument function in argparse. ( …
4b4b926 
pythonGH-8766)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@sp1rs @DinoV
Remove redundant if check from optional argument function in argparse. ( …
5ee7076 
pythonGH-8766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sp1rs @the-knights-who-say-ni @asottile @benjaminp @bedevere-bot @miss-islington