◐ Shell
reader mode source ↗
Skip to content

bpo-34515: lib2to3: support non-ASCII identifiers#8950

Merged
benjaminp merged 4 commits into
python:masterfrom
holymonson:non_ascii_identifiers
Sep 15, 2018
Merged

bpo-34515: lib2to3: support non-ASCII identifiers#8950
benjaminp merged 4 commits into
python:masterfrom
holymonson:non_ascii_identifiers

Conversation

@holymonson

@holymonson holymonson commented Aug 27, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@holymonson holymonson mentioned this pull request Aug 27, 2018
Closed
@holymonson

holymonson commented Aug 27, 2018

Copy link
Copy Markdown
Contributor Author

this will fix google/yapf#607

@holymonson holymonson force-pushed the non_ascii_identifiers branch from 1b3072b to 50f189e Compare August 27, 2018 12:51
@holymonson holymonson force-pushed the non_ascii_identifiers branch from 50f189e to 37d8770 Compare September 15, 2018 02:53
@benjaminp benjaminp merged commit 10a428b into python:master Sep 15, 2018
@miss-islington

miss-islington commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

Thanks @holymonson for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2018
@holymonson @miss-islington
closes bpo-34515: Support non-ASCII identifiers in lib2to3. (pythonGH… …
a9f58c2 
…-8950)

(cherry picked from commit 10a428b)

Co-authored-by: Monson Shao <holymonson@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 15, 2018

Copy link
Copy Markdown

GH-9333 is a backport of this pull request to the 3.7 branch.

@ambv

ambv commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

@benjaminp What we actually want is to merge the two pure Python tokenizers. This pull request makes this harder.

@ambv

ambv commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

See BPO-33338.

@benjaminp

benjaminp commented Sep 15, 2018 via email

Copy link
Copy Markdown
Contributor

@ambv

ambv commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

I'm thinking. My change will only affect Python 3.8 so the backport PR (GH-9333) does make life of YAPF users better in the interim. I'll revert on master only when I rebase my tokenizer merge pull request.

@ambv

ambv commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

IOW, let's leave it for now.

miss-islington added a commit that referenced this pull request Sep 15, 2018
@miss-islington @holymonson
closes bpo-34515: Support non-ASCII identifiers in lib2to3. (GH-8950) …
51dbae8 
(cherry picked from commit 10a428b)

Co-authored-by: Monson Shao <holymonson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp left review comments

+1 more reviewer

@kamahen kamahen kamahen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@holymonson @miss-islington @bedevere-bot @ambv @benjaminp @kamahen @the-knights-who-say-ni