bpo-29546: Set path on ImportError for from ... import#91

Carreau

And path as well when existing.

See bpo-29546

This is a step toward providing better error messages in case of
from-import. Barry Warsaw Proposed:

cannot import name {name} from {module} ({path})

But that's probably going to trigger more discussions that filling in
already existing fields.

I'm not familiar with C-internal of CPython, So let me know if I'm doing things wrong.

brettcannon

I have not dug into the surrounding code, but the general approach LGTM.

brettcannon

I also just realized there's no test.

brettcannon

Please add a test.

Carreau

I also just realized there's no test.

Yes I realized that as well :-) Will do .

codecov

Codecov Report

❗ No coverage uploaded for pull request base (master@6de2b78). Click here to learn what that means.
The diff coverage is 64.28%.

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage          ?   82.38%           
=========================================
  Files             ?     1428           
  Lines             ?   351163           
  Branches          ?        0           
=========================================
  Hits              ?   289314           
  Misses            ?    61849           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de2b78...32e42aa. Read the comment docs.

berkerpeksag

BTW, please rebase your branch so we can get rid of these Codecov comments :)

And `path` as well when existing. See bpo-29546 This is a step toward providing better error messages in case of from-import. Barry Warsaw Proposed: cannot import name {name} from {module} ({path}) But that's probably going to trigger more discussions that filling in already existing fields.

Make sure they name and path are set in various case.

Carreau

BTW, please rebase your branch so we can get rid of these Codecov comments :)

Oh gosh 71 was merged ? Thanks you! and done.

brettcannon

LGTM! Thanks for sticking through it, @Carreau !

Please add yourself to Misc/ACKS if you're not already there and add an entry into Misc/NEWS like:

bpo-29546: Set the 'path' attribute on ImportError for ``from ... import ...``.

Carreau

changed the title from bpo-29546: Set name on ImportError for from ... import to bpo-29546: Set path on ImportError for from ... import

Well actually good point that's setting both name and path. Name was not set either if that matters.

Please add yourself to Misc/ACKS if you're not already there and add an entry into Misc/NEWS like:

Sure !

brettcannon

Thanks! As soon as Travis is green I'll merge.

Carreau

Thanks! As soon as Travis is green I'll merge.

Thanks. I don't know how disturbing the migration has been from your end (and other core dev).
From my side being able to use git and PRs was great.

Many kudos for having worked on the migration for so long.

brettcannon

Merged! Thanks again!

And I'm glad that the new workflow worked out for you! As for me, the new workflow let me review this PR throughout the day when I had time and do it entirely in the browser so I didn't have to remember to commit it when I got home (if I had to cherry-pick that would not have been the case, but I could at least merge now and cherry-pick later if need be).

Carreau

if I had to cherry-pick that would not have been the case

Hopping you will get the cherry-pick bot soon. Thanks for the time you've put into this.
I probably owe you a "orange juice, root beer, or Canada Dry," when we meet IRL.

brettcannon

@Carreau the bot would be great, but at worst me or someone else can write a Python script probably to automate it locally if necessary (which reminds me, I should write that idea down over on core-workflow).

Carreau

which reminds me, I should write that idea down over on core-workflow

You did python/core-workflow#8 (Bot to automatically generate cherry-picking PRs)

warsaw

Wow, I'm very pleasantly impressed at how quickly my bug/idea went to (nearly) implemented through the new workflow. Kudos!

Carreau

Wow, I'm very pleasantly impressed at how quickly my bug/idea went to (nearly) implemented through the new workflow. Kudos!

Happy to repay a bit for all the work you did.

It's also much easier to decide to implement if a core dev have pitched in the idea, as it has more chance to be accepted. Thanks both !

Add location information like canonical module name where identifier cannot be found and file location if available. First iteration of this was pythongh-91

…ursion depth Reset the recursion depth in PyTasklet_BindEx and add a few asserts. This fixes issue python#91. Add a test case for the recursion depth and as test case for an assertion failure caused by this bug. https://bitbucket.org/stackless-dev/stackless/issues/91 (grafted from 1584a89fca366f66dadf3cf04f0306dd45b1372f and 380b70b1933d)

Implements scripts/w45_bridge_drift_falsifier.sh per docs/w45-bridge-signature-drift-falsifier.md. Mutate-Build-Verify-Restore loop: - Mutates a bridge signature (extern "C" decl in builder.cpp + function definition in builder_emit_c.c, in lockstep) by appending a sentinel param 'int phx_w45_drift'. - Verifies the build fails at the C++ dispatch-switch call site (which has the OLD arity). - Restores both files; clean rebuild verifies tree state. Catches the structural drift class identified by pythia python#90/python#91: void* args at the bridge crossing erase the type-safety C++ overload resolution would normally provide. 252+ dispatch sites in builder.cpp post Phase 1 burndown — manual audit unscalable. Initial 6 fixtures (per spec §2.2 + §2.6 retro): - hir_builder_emit_before_with_c (Phase 1 python#6 retro) - hir_builder_emit_setup_with_c (Phase 1 python#7 retro) - hir_builder_emit_format_simple_c (Phase 1 python#2 sample) - hir_builder_emit_copy_free_vars_c (Phase 1 python#4 sample) - hir_builder_emit_get_yield_from_iter_c (Phase 1 python#4 sample) - hir_builder_emit_primitive_load_const_c (Phase 1 python#5 sample) Modes: - --dry-run: stage mutations, no build (any agent — bypass build lock) - --strict: exit 1 on FAIL (for gate integration) - --verbose: show build stderr Uses perl -0777 multi-line slurp for robust parsing of multi-line extern decls + function definitions. Mutation marker (phx_w45_drift) verified post-mutation to guard against silent no-op substitutions. Build lock: BUILD mode invokes cmake --build --target jit; per CLAUDE.md Phase 3D Build Lock, only testkeeper / gate_phoenix.sh may invoke with builds enabled. --dry-run is unrestricted. Authorization: theologian 21:55:24Z + supervisor 21:55:36Z + 22:33:17Z DISPOSITION (C). §3.5 fold-into-C derivation falsifier (opcode-constant shadow class) is deferred — needs W21 golden integration. Sibling workstreams: W33 (zero-bridge verifier), W42 (refcount correctness), W44 (DO-NOT-USE caller gate).

the-knights-who-say-ni added the CLA signed label Feb 14, 2017

brettcannon reviewed Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch from bd14cf2 to d3aff79 Compare February 14, 2017 18:27

brettcannon requested changes Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch 2 times, most recently from 3f218f5 to 30a5055 Compare February 14, 2017 21:57

brettcannon requested changes Feb 14, 2017

View reviewed changes

Carreau force-pushed the betterimport branch from 30a5055 to 32e42aa Compare February 14, 2017 22:39

Carreau added 2 commits February 14, 2017 14:48

Add test for the from ... import behavior. …

7456cfc

Make sure they name and path are set in various case.

Carreau force-pushed the betterimport branch from 32e42aa to 7456cfc Compare February 14, 2017 22:48

brettcannon changed the title ~~bpo-29546: Set name on ImportError for from ... import~~ Feb 14, 2017

brettcannon approved these changes Feb 14, 2017

View reviewed changes

Add entry into Misc/NEWS

96b967a

brettcannon merged commit bc4bed4 into python:master Feb 15, 2017

Carreau deleted the betterimport branch February 15, 2017 00:08

Carreau mentioned this pull request Feb 15, 2017

bpo-29546: Improve from-import error message with location #103

Merged

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Update celery from 4.1.0 to 4.1.1 (#91)

8ef6673

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

ngoldbaum mentioned this pull request Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

sergey-miryanov mentioned this pull request Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

alexkats mentioned this pull request May 18, 2026

gh-149816: Fix UAF in Modules/_pickle.c #150024

Merged

Conversation

Carreau commented Feb 14, 2017

Uh oh!

brettcannon commented Feb 14, 2017

Uh oh!

brettcannon commented Feb 14, 2017

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Carreau commented Feb 14, 2017

Uh oh!

codecov Bot commented Feb 14, 2017

Codecov Report

Uh oh!

berkerpeksag commented Feb 14, 2017

Uh oh!

Carreau commented Feb 14, 2017

Uh oh!

brettcannon commented Feb 14, 2017

Uh oh!

Carreau commented Feb 14, 2017

Uh oh!

brettcannon commented Feb 14, 2017

Uh oh!

Carreau commented Feb 15, 2017

Uh oh!

brettcannon commented Feb 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Carreau commented Feb 15, 2017

Uh oh!

brettcannon commented Feb 15, 2017

Uh oh!

Carreau commented Feb 15, 2017

Uh oh!

warsaw commented Feb 15, 2017

Uh oh!

Carreau commented Feb 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brettcannon commented Feb 15, 2017 •

edited

Loading