{{ message }}
gh-91621: Fix typing.get_type_hints for collections.abc.Callable#91656
Merged
JelleZijlstra merged 5 commits intoMay 2, 2022
Merged
gh-91621: Fix typing.get_type_hints for collections.abc.Callable#91656JelleZijlstra merged 5 commits into
JelleZijlstra merged 5 commits into
Conversation
Contributor
Sorry, something went wrong.
This mirrors logic in typing.get_args. The trickiness comes from how we flatten args in collections.abc.Callable, see https://bugs.python.org/issue42195
hauntsaninja
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
April 18, 2022 04:31
Contributor
Author
|
I think we can skip news since this is just a fix for the unreleased #30900 |
Sorry, something went wrong.
AlexWaygood
added
type-bug
An unexpected behavior, bug, or error
topic-typing
stdlib
Standard Library Python modules in the Lib/ directory
labels
Apr 18, 2022
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
JelleZijlstra
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This mirrors logic in typing.get_args. The trickiness comes from how we
flatten args in collections.abc.Callable, see
https://bugs.python.org/issue42195
#91621