◐ Shell
reader mode source ↗
Skip to content

gh-87452 Making returncode unreliability explicit#92181

Merged
gpshead merged 19 commits into
python:mainfrom
zitterbewegung:gh-87452
Apr 24, 2023
Merged

gh-87452 Making returncode unreliability explicit#92181
gpshead merged 19 commits into
python:mainfrom
zitterbewegung:gh-87452

Conversation

@zitterbewegung

@zitterbewegung zitterbewegung commented May 2, 2022 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

We make explicit that the value stored in return code is best returned by poll instead of using the value in return code.

gh-87452: Making returncode unreliability explicit

@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 2, 2022
@zitterbewegung zitterbewegung changed the title Making returncode unreliability explicit May 2, 2022
@benjaminp

benjaminp commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thank you for the PR.

I don't think "out-of-date" is the right term here. Either the entire subprocess.Subprocess instance is aware of the exit of the child process and knows the return code, or it doesn't. The first paragraph of the method documentation could perhaps be rearranged to more clearly state the order of events instead of appending another sentence.

@benjaminp

benjaminp commented May 2, 2022

Copy link
Copy Markdown
Contributor

I would propose:

The child return code. Initially ``None``, :attr:`returncode` is set by :meth:`poll` and :meth:`wait` after process termination is observed.
``

@erlend-aasland

erlend-aasland commented May 3, 2022

Copy link
Copy Markdown
Contributor

Please remove the duplicate NEWS entry.

@zitterbewegung @arhadthedev
Update Doc/library/subprocess.rst …
4adaaab 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
erlend-aasland
erlend-aasland requested changes Oct 14, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Again, please remove the duplicate NEWS entry. Also please address Benjamin's remarks.

@bedevere-bot

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@slateny

slateny commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

@zitterbewegung Would you still be interested in giving the PR a quick update per the reviews above?

@zitterbewegung

zitterbewegung commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

Sorry I can do that.

@zitterbewegung
Updating docs for formatting issues. …
ca4ea71 
Wrapping to 79 characters.
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
Closed
@netlify

netlify Bot commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 41a5d22
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/638f5503b72cc30008de175b
😎 Deploy Preview https://deploy-preview-92181--python-cpython-preview.netlify.app/whatsnew/changelog
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

6 hidden items Load more…
zitterbewegung
zitterbewegung commented Dec 6, 2022
View reviewed changes

@zitterbewegung zitterbewegung left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment
  • Fixed word wrap issue
  • Removed duplicate news entry.

@hugovk hugovk mentioned this pull request Dec 6, 2022
Merged
zitterbewegung
zitterbewegung commented Dec 6, 2022
View reviewed changes

@zitterbewegung zitterbewegung left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Removed trailing whitespace

@zitterbewegung

zitterbewegung commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Dec 6, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@zitterbewegung

zitterbewegung commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

@erlend-aasland can this be reviewed?

@gpshead gpshead self-assigned this Apr 24, 2023
@gpshead gpshead added needs backport to 3.11 only security fixes labels Apr 24, 2023
@gpshead gpshead merged commit 68f5836 into python:main Apr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @zitterbewegung for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@erlend-aasland

erlend-aasland commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Sorry for the delay; thanks Greg for merging. Thanks for the PR, Joshua.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp left review comments

@arhadthedev arhadthedev arhadthedev left review comments

@slateny slateny slateny left review comments

@furkanonder furkanonder furkanonder approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@zitterbewegung @bedevere-bot @benjaminp @erlend-aasland @slateny @miss-islington @arhadthedev @furkanonder @gpshead @terryjreedy