◐ Shell
reader mode source ↗
Skip to content

[3.6] bpo-34200: Fix non-determinism of test_pkg (GH-9248)#9253

Merged
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-4ae8ece-3.6
Sep 13, 2018
Merged

[3.6] bpo-34200: Fix non-determinism of test_pkg (GH-9248)#9253
miss-islington merged 1 commit into
python:3.6from
miss-islington:backport-4ae8ece-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 13, 2018

Copy link
Copy Markdown
Contributor

This causes the tearDown code to only unimport the test modules specifically created as part of each test via the self.mkhier method rather than abusing test.support.modules_setup() and the scary test.support.modules_cleanup() code.

https://bugs.python.org/issue34200
(cherry picked from commit 4ae8ece)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue34200

This causes the tearDown code to only unimport the test modules specifically created as part of each test via the self.mkhier method rather than abusing test.support.modules_setup() and the scary test.support.modules_cleanup() code.

https://bugs.python.org/issue34200
(cherry picked from commit 4ae8ece)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3e3d4a4 into python:3.6 Sep 13, 2018
@miss-islington miss-islington deleted the backport-4ae8ece-3.6 branch September 13, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants