◐ Shell
reader mode source ↗
Skip to content

gh-61441: XML entity expansion limitation#9265

Closed
tiran wants to merge 1 commit into
python:mainfrom
tiran:bpo17239-expat-limit
Closed

gh-61441: XML entity expansion limitation#9265
tiran wants to merge 1 commit into
python:mainfrom
tiran:bpo17239-expat-limit

Conversation

@tiran

@tiran tiran commented Sep 13, 2018 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@tiran tiran added type-security A security issue DO-NOT-MERGE labels Sep 13, 2018
@vstinner

vstinner commented Sep 13, 2018

Copy link
Copy Markdown
Member

I would prefer to see this change made in expat upstream. We should vendor an unmodified version of expat.

@tiran

tiran commented Sep 13, 2018

Copy link
Copy Markdown
Member Author

That's the plan.

@vstinner vstinner changed the title bpo-17239: XML entity expansion limitation Sep 13, 2018
@tiran tiran force-pushed the bpo17239-expat-limit branch from a172a25 to 053db1d Compare September 14, 2018 17:17
@zooba

zooba commented Sep 17, 2018

Copy link
Copy Markdown
Member

Since we ship the vendored one as part of the Windows release, I'd be happy to have this merged for 3.7.1 while we wait for the patch to go upstream.

This is not our public API, so even if they upstream a different version of it, that won't affect us.

@tiran tiran force-pushed the bpo17239-expat-limit branch 4 times, most recently from 6a51752 to 2cffc90 Compare September 20, 2018 11:30
@tiran
bpo-17239: XML entity expansion limitation …
504e092 
Modelled after https://github.com/GNOME/libxml2/blob/v2.9.8/parser.c#L99

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo17239-expat-limit branch from 2cffc90 to 504e092 Compare September 23, 2018 11:54
@matrixise

matrixise commented Sep 10, 2019

Copy link
Copy Markdown
Member

@tiran maybe we could close this issue, +- 1y and I suppose expat has been updated.

@arhadthedev

arhadthedev commented Mar 30, 2022

Copy link
Copy Markdown
Member

@tiran Is the PR still relevant?

@erlend-aasland erlend-aasland changed the title [WIP] bpo-17239: XML entity expansion limitation Jan 4, 2024
@erlend-aasland erlend-aasland marked this pull request as draft January 4, 2024 10:14
@github-actions

github-actions Bot commented Dec 15, 2024

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 15, 2024
@gpshead

gpshead commented May 24, 2025

Copy link
Copy Markdown
Member

closing as external entity expansion was disabled in sax other PRs (see issue)

@gpshead gpshead closed this May 24, 2025
@gpshead gpshead mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@disconnect3d disconnect3d disconnect3d left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO-NOT-MERGE stale Stale PR or inactive for long period of time. type-security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.